From dev-return-11046-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Tue Mar 17 15:51:16 2009 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 41513 invoked from network); 17 Mar 2009 15:51:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Mar 2009 15:51:16 -0000 Received: (qmail 67739 invoked by uid 500); 17 Mar 2009 15:51:15 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 67702 invoked by uid 500); 17 Mar 2009 15:51:14 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 67413 invoked by uid 99); 17 Mar 2009 15:51:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 08:51:13 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 15:51:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 885F5234C003 for ; Tue, 17 Mar 2009 08:50:50 -0700 (PDT) Message-ID: <1392033765.1237305050544.JavaMail.jira@brutus> Date: Tue, 17 Mar 2009 08:50:50 -0700 (PDT) From: "Jeremy Bauer (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-885) Support clear methods on EntityManager, including new CascadeType.CLEAR In-Reply-To: <2105410322.1233353099564.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682702#action_12682702 ] Jeremy Bauer commented on OPENJPA-885: -------------------------------------- I've reviewed detachCodePatch.txt and detachTestPatch.txt dated 16/Mar/09 07:16 AM. Nice work. The changes look good to me. Unless someone has issues with any of the changes, I'll commit them later today. Some comments: - Don't forget to provide documentation updates - Tests that use cascade defined in xml - for both cascade clear and all need to be provided. I can partially see why they weren't provided (or even obvious), since the current orm.xml doesn't have the cascade-clear element defined. I'll mention the missing element to Kevin so he can help make sure it gets included in a future revision of the 2.0 spec. I recommend creating a new JIRA for the future work (using cascade-clear defined in orm.xml & corresponding updates in the XML parser) so this work item can be resolved. > Support clear methods on EntityManager, including new CascadeType.CLEAR > ------------------------------------------------------------------------ > > Key: OPENJPA-885 > URL: https://issues.apache.org/jira/browse/OPENJPA-885 > Project: OpenJPA > Issue Type: Sub-task > Affects Versions: 2.0.0 > Reporter: Dianne Richards > Assignee: Dianne Richards > Fix For: 2.0.0 > > Attachments: CompatibilityProblemPatch.txt, detachCodePatch.txt, detachTestPatch.txt, patch.txt > > > Support the 2.0 new EntityManager clear() methods. Also support the new CascadeType.CLEAR. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.