From dev-return-10744-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Mon Mar 02 16:13:26 2009 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 31064 invoked from network); 2 Mar 2009 16:13:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Mar 2009 16:13:25 -0000 Received: (qmail 39916 invoked by uid 500); 2 Mar 2009 16:13:25 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 39896 invoked by uid 500); 2 Mar 2009 16:13:25 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 39885 invoked by uid 99); 2 Mar 2009 16:13:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2009 08:13:25 -0800 X-ASF-Spam-Status: No, hits=-1999.8 required=10.0 tests=ALL_TRUSTED,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2009 16:13:17 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 1B1B7234C48C for ; Mon, 2 Mar 2009 08:12:56 -0800 (PST) Message-ID: <1055127996.1236010376096.JavaMail.jira@brutus> Date: Mon, 2 Mar 2009 08:12:56 -0800 (PST) From: "Alan Raison (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-866) DBDictionary.maxTableNameLength is not checked when using SynchronizeMappings In-Reply-To: <460824889.1232722499495.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678029#action_12678029 ] Alan Raison commented on OPENJPA-866: ------------------------------------- I've just tried to run the test "org.apache.openjpa.enhance.TestDataCachingAndUnenhancedPropertyAccess" with the patched sources, but I still get: Table name "UnenhancedIdentityIdPropertyAccess" is 34-character long. The database allows maximum 32-character for a table name. How did you test the patch? Let me know and I will try to replicate that. > DBDictionary.maxTableNameLength is not checked when using SynchronizeMappings > ----------------------------------------------------------------------------- > > Key: OPENJPA-866 > URL: https://issues.apache.org/jira/browse/OPENJPA-866 > Project: OpenJPA > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: Alan Raison > Assignee: Tim McConnell > Attachments: OPNEJPA-866.patch > > > Per Alan Raison's post to the dev mailing list there appears to be a problem with trimming table names when SynchronizeMappings is used. > Here's the email that started the conversation : > I have been writing a DBDictionary for the Ingres database and have been running the test cases. Ingres supports 32 character table names, and this has been set in the dictionary. However some tests have hit an error whereby the table name is too long for the database. > I notice in the DBDictionary class there is a method called "getValidTableName" but this clearly isn't being used since it is trying to use a table name which is too long. Other databases (such as Oracle) also have quite a short maximum length for table names, so this problem must be able to overcome, but I can't see anything in other Dictionary classes. > Is there anything special I should be doing to run the tests? I am currently running through mvn test. > My draft DBDictionary class is attached along with a sample surefire report (with my username and password removed!) > The full thread can be seen here : http://n2.nabble.com/OpenJPA-1.2.0-Test-Cases---Table-Name-too-Long-td2197132.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.