openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-887) Assertion oversight in TestLibService
Date Tue, 31 Mar 2009 20:38:50 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694257#action_12694257
] 

Michael Dick commented on OPENJPA-887:
--------------------------------------

No worries Milosz. I've gone ahead and corrected the svn log settings for both releases. 

FWIW you can do this by running the following commands : 

$ svn ps -r 759470 --revprop svn:log "OPENJPA-887" https://svn.apache.org/repos/asf/openjpa/trunk

$ svn ps -r 759473 --revprop svn:log "OPENJPA-887" https://svn.apache.org/repos/asf/openjpa/branches/1.3.x/

The SVN FAQ has complete documentation at http://subversion.tigris.org/faq.html#change-log-msg.

Obviously you're not the first to do this ;-)


> Assertion oversight in TestLibService
> -------------------------------------
>
>                 Key: OPENJPA-887
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-887
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Trivial
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back
to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...).  The above compiles because of autoboxing
creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message