openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pinaki Poddar (JIRA)" <j...@apache.org>
Subject [jira] Updated: (OPENJPA-1015) Enforce 80-column line width for source code
Date Tue, 31 Mar 2009 22:04:51 GMT

     [ https://issues.apache.org/jira/browse/OPENJPA-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pinaki Poddar updated OPENJPA-1015:
-----------------------------------

    Attachment: line80.txt
                TestLineWidth.java

1. A simple test to detect all 80+ characters line in openjpa source code. Harcoded some module
paths.

2. Output showing the list of violated lines. There are 138 affected files each carrying 1-14
lines that exceed 80-char limit. 

    First few lines of the output....

Following 138 files contain lines wider than 80 characters
 1	C:\work\openjpa-1.3.0\openjpa-persistence\src\main\java\org\apache\openjpa\persistence\AnnotationBuilder.java:[179]
 7	C:\work\openjpa-1.3.0\openjpa-persistence\src\main\java\org\apache\openjpa\persistence\AnnotationPersistenceMetaDataParser.java:[31,
32, 538, 590, 595, 599, 603]
 3	C:\work\openjpa-1.3.0\openjpa-persistence\src\main\java\org\apache\openjpa\persistence\AnnotationPersistenceMetaDataSerializer.java:[492,
1240, 1308]
 1	C:\work\openjpa-1.3.0\openjpa-persistence\src\main\java\org\apache\openjpa\persistence\AnnotationPersistenceXMLMetaDataParser.java:[283]

> Enforce 80-column line width for source code
> --------------------------------------------
>
>                 Key: OPENJPA-1015
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1015
>             Project: OpenJPA
>          Issue Type: Test
>            Reporter: Pinaki Poddar
>         Attachments: line80.txt, TestLineWidth.java
>
>
> There used to be a rule of 80-column width for source code.
> That rule is slowly yielding. 
> Should we add a test case to catch such violation?
> Or should we not reignite the age-old battle about line width, placement of brackets
etc?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message