openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Milosz Tylenda (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (OPENJPA-887) Assertion oversight in TestLibService
Date Sat, 28 Mar 2009 15:00:50 GMT

     [ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Milosz Tylenda resolved OPENJPA-887.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
                   1.3.0

The patch applied to trunk and 1.3.x branch.

I am sorry the trunk commit went without message - I made a kind of "do-it-first-time" mistake.
The trunk revision is 759470.


> Assertion oversight in TestLibService
> -------------------------------------
>
>                 Key: OPENJPA-887
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-887
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
>            Reporter: Milosz Tylenda
>            Assignee: Milosz Tylenda
>            Priority: Trivial
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back
to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...).  The above compiles because of autoboxing
creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message