openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremy Bauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-885) Support clear methods on EntityManager, including new CascadeType.CLEAR
Date Tue, 17 Mar 2009 15:50:50 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682702#action_12682702
] 

Jeremy Bauer commented on OPENJPA-885:
--------------------------------------

I've reviewed detachCodePatch.txt and detachTestPatch.txt dated 16/Mar/09 07:16 AM.  Nice
work.  The changes look good to me.  Unless someone has issues with any of the changes, I'll
commit them later today.

Some comments:
- Don't forget to provide documentation updates 
- Tests that use cascade defined in xml - for both cascade clear and all need to be provided.
 I can partially see why they weren't provided (or even obvious), since the current orm.xml
doesn't have the cascade-clear element defined.  I'll mention the missing element to Kevin
so he can help make sure it gets included in a future revision of the 2.0 spec.  I recommend
creating a new JIRA for the future work (using cascade-clear defined in orm.xml & corresponding
updates in the XML parser) so this work item can be resolved.

> Support clear methods on EntityManager, including new CascadeType.CLEAR 
> ------------------------------------------------------------------------
>
>                 Key: OPENJPA-885
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-885
>             Project: OpenJPA
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Dianne Richards
>            Assignee: Dianne Richards
>             Fix For: 2.0.0
>
>         Attachments: CompatibilityProblemPatch.txt, detachCodePatch.txt, detachTestPatch.txt,
patch.txt
>
>
> Support the 2.0 new  EntityManager clear() methods. Also support the new CascadeType.CLEAR.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message