Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: domain of michael.d.dick@gmail.com
 designates 209.85.134.186 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=pj9ywkw+wgmoHMCrGCOr0YoY2kTqVMspPfZ9y+nsBm6mO77ME8exoy4X90AGME822G
         jaSrDlJgTn5Xs73r1KMFU1iXJsjWYhHnXEcpOVdg/KW9Zmx1qyBMXjURj/M6EhwW8lFc
         Efa9ZBF/YeSEkiTk/ckVmt+LePMOGqKHRzF9M=
MIME-Version: 1.0
In-Reply-To: <219e184e.6208015e.49882135.498bd@o2.pl>
References: <219e184e.6208015e.49882135.498bd@o2.pl>
Date: Tue, 3 Feb 2009 10:30:17 -0600
Message-ID: <72c1350f0902030830n418196bdndab8716a69f1324@mail.gmail.com>
Subject: Re: Revision 736066 of TestMultipleSchemaNames
From: Michael Dick <michael.d.dick@gmail.com>
To: dev@openjpa.apache.org
Content-Type: multipart/alternative; boundary=001636c5a736bee9b10462062f08

--001636c5a736bee9b10462062f08
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable

Hi Milosz,

Sorry about that (obviously) I didn't run that change on PostGres and I
missed the comments. For now I'm going to just remove the
System.err.println. Alternatively we could catch and re-throw the exception
after cleaning up.

Just running a sanity check build before committing.


On Tue, Feb 3, 2009 at 4:49 AM, Mi=B3osz Tylenda <mtylenda@o2.pl> wrote:

> Hi Mike,
>
> I am afraid that this change (removing try/catch) will prevent running th=
e
> test (at least the first method) on PostgreSQL more than once. PostgreSQL
> needs explicit schema creation and the try/catch code was the easiest way=
 I
> could find to handle the case when schemas are already created. Let me kn=
ow
> if you think this should be done in another way.
>
> Also, the closing of emf at the bottom of the method should rather stay a=
s
> before as the emf is not used outside of the method.
>
> This schema creation stuff was added to harness a bug concerning
> autoincrement columns in PostgreSQL. The diff follows.
>
> Greetings,
> Milosz
>
> ---
> openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/p=
ersistence/generationtype/TestMultipleSchemaNames.java
> (original)
> +++
> openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/p=
ersistence/generationtype/TestMultipleSchemaNames.java
> Tue Jan 20 11:01:50 2009
> @@ -417,19 +417,11 @@
>         String[] schemas =3D
>             { "SCHEMA1", "SCHEMA2", "SCHEMA3", "SCHEMA3G", "SCHEMA4G" };
>         for (String schema : schemas) {
> -            try {
> -                em.getTransaction().begin();
> -                Query q =3D em.createNativeQuery("create schema " + sche=
ma);
> -                q.executeUpdate();
> -                em.getTransaction().commit();
> -            } catch (PersistenceException e) {
> -                System.err.println("Exception caught while creating sche=
ma
> "
> -                    + schema + ". Schema already exists? Message: "
> -                    + e.getMessage());
> -                em.getTransaction().rollback();
> -            }
> +            em.getTransaction().begin();
> +            Query q =3D em.createNativeQuery("create schema " + schema);
> +            q.executeUpdate();
> +            em.getTransaction().commit();
>         }
> -        closeEMF(emf);
>     }
>

--001636c5a736bee9b10462062f08--