Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 55150 invoked from network); 5 Feb 2009 15:32:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Feb 2009 15:32:23 -0000 Received: (qmail 35487 invoked by uid 500); 5 Feb 2009 15:32:22 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 35469 invoked by uid 500); 5 Feb 2009 15:32:22 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 35433 invoked by uid 99); 5 Feb 2009 15:32:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2009 07:32:22 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2009 15:32:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A303D234C495 for ; Thu, 5 Feb 2009 07:31:59 -0800 (PST) Message-ID: <548639956.1233847919666.JavaMail.jira@brutus> Date: Thu, 5 Feb 2009 07:31:59 -0800 (PST) From: "Michael Dick (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-884) Logging oversight in DB2Dictionary In-Reply-To: <544845590.1233326399667.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670792#action_12670792 ] Michael Dick commented on OPENJPA-884: -------------------------------------- I noticed the same thing about history in SVN. This code was added when OpenJPA was in the incubator. If the incubator's svn repository is still available we could probably find it there. I think I agree with you regarding removing the try / catch. Seems to me if we can't detect the version of DB2 we'd want to fail early rather than having an empty forUpdateClause. Catalina, do you have a recommendation? You've done a lot of work with DB2 and might remember when this code was added. > Logging oversight in DB2Dictionary > ---------------------------------- > > Key: OPENJPA-884 > URL: https://issues.apache.org/jira/browse/OPENJPA-884 > Project: OpenJPA > Issue Type: Bug > Components: logging > Affects Versions: 1.2.0, 1.2.1, 1.3.0, 2.0.0-M1, 2.0.0 > Reporter: Milosz Tylenda > Assignee: Michael Dick > Priority: Trivial > Attachments: OPENJPA-884.patch > > > There is a small oversight in DB2Dictionary - there is a check whether TRACE level is enabled and then an exception is logged on ERROR level. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.