openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremy Bauer (JIRA)" <>
Subject [jira] Commented: (OPENJPA-896) Several source files include Windows EoL chars
Date Fri, 27 Feb 2009 21:11:12 GMT


Jeremy Bauer commented on OPENJPA-896:

+1 use a single JIRA.

+1 we do it in a single big commit (ie no functional changes)

If the change is made, can you (Donald) inform folks on how to setup their environment so
that we don't end up back in the same state in the future?  Commits to existing files are
not typically an issue, but new files using Windows eol's may get committed without proper
setup.  I've probably committed a few, myself.  :-)

> Several source files include Windows EoL chars
> ----------------------------------------------
>                 Key: OPENJPA-896
>                 URL:
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: docs
>    Affects Versions: 1.0.3, 1.1.0, 1.2.0
>            Reporter: Donald Woods
>            Assignee: Michael Dick
>            Priority: Trivial
>             Fix For: 1.0.4, 1.2.1, 1.3.0, 2.0.0
>         Attachments: OPENJPA-896-trunk-withprops.patch, OPENJPA-896-trunk.patch
> Several of the doc files include the Windows Ctrl+M chars at the end of lines when checked
out to non-Windows platforms (like MacOSX and Linux), due to the committer not using the ASF
suggested svn config values -
> From -
> Configuring the Subversion client
> Committers will need to properly configure their svn client. One particular issue is
OS-specific line-endings for text files. When you add a new text file, especially when applying
patches from Bugzilla, first ensure that the line-endings are appropriate for your system,
then do ...
> svn add test.txt
> svn propset svn:eol-style native test.txt
> Your svn client can be configured to do that automatically for some common file types.
Add the contents of the file to your ~/.subversion/config
file. [Note: for Windows this is normally found at C:\Documents and Settings\{username}\Application
> Some files may need additional properties to be set, for example svn:executable=* should
be applied to those script files (e.g. .bat, .cgi, .cmd, .sh) that are intended to be executed.
Since not all such files are necessarily intended to be executed, the executable property
should not be made an automatic default.
> However, you should still pay attention to the messages from your svn client when you
do 'svn commit'.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message