openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Albert Lee <allee8...@gmail.com>
Subject Re: svn commit: r743396 - in /openjpa/trunk: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/conf/ openjpa-kernel/src/main/java/org/apache/openjpa/enhance/ openjpa-kernel/src/main/java/org/apache/openjpa/kernel/ openjpa-lib/src/main/java/org/apach
Date Wed, 11 Feb 2009 22:56:28 GMT
When Don points out the use of

   assertEquals(5671, query.getFetchPlan().getQueryTimeout());

I assume the getQueryTimeout() method exists in the FetchPlan interface, but
it is NOT. So you are correct that the getLockTimeout() is the only value
that can be used for testing.

However the introduction of the following javax.persistence.* properties in
OpenJPAConfiguration force us to address the same very issue:

        lockTimeout = addInt("LockTimeout");
        lockTimeout.addEquivalentKey("javax.persistence.lock.timeout");

        queryTimeout = addInt("javax.persistence.query.timeout");
        queryTimeout.setLoadKey("javax.persistence.query.timeout");

With this specification, one would expect 2 different values can be set
independent of each other. The use of the lockTimeout field in
FetchConfigurationImpl is not sufficient to support this behavior.

Albert Lee.

On Wed, Feb 11, 2009 at 2:45 PM, Pinaki Poddar <ppoddar@apache.org> wrote:

>
> Hi,
>  Which interface/class defines getQueryTimeout() to test?
>  In any case, please go ahead to change the test or (better) add a new one.
>
>
> --
> View this message in context:
> http://n2.nabble.com/Re%3A-svn-commit%3A-r743396---in--openjpa-trunk%3A-openjpa-jdbc-src-main-java-org-apache-openjpa-jdbc-conf---openjpa-kernel-src-main-java-org-apache-openjpa-enhance--openjpa-kernel-src-main-java-org-a-tp2311149p2311244.html
> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>
>


-- 
Albert Lee.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message