openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: bug: selectDistinct(List<SelectItem> items) in apache-openjpa-2.0.0-SNAPSHOT
Date Thu, 26 Feb 2009 15:08:06 GMT
Are you proposing the following change?

  public QueryDefinition selectDistinct(List<SelectItem> items) {
-  return select(items, false);
+  return select(items, true);
  }

Please open a JIRA so we can check in the fix and consider if we need a 
new junit testcase to cover this.

Thanks.
-Donald

Tan bupt wrote:
> I think it is a bug in
> org.apache.openjpa.persistence.query.QueryDefinitionImpl, can we fix it?
> 
>  public QueryDefinition selectDistinct(SelectItem... items) {
>   return select(items == null ? null : Arrays.asList(items), true);
>  }
>  public QueryDefinition selectDistinct(List<SelectItem> items) {
>   return select(items, false);
>  }
> 
>  private QueryDefinition select(List<SelectItem> items, boolean isDistinct)
> {
>   if (_projections == null) {
>    _projections = new ArrayList<SelectItem>();
>   } else {
>    _projections.clear();
>   }
>   _distinct = isDistinct;
>   for (SelectItem item : items)
>    _projections.add(item);
>   return this;
>  }
> 

Mime
View raw message