openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Albert Lee (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-770) Use annotations instead of excluding tests in pom.xml
Date Fri, 20 Feb 2009 19:35:01 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675445#action_12675445
] 

Albert Lee commented on OPENJPA-770:
------------------------------------

Tim,  Thanks for providing the new patch.
---------------------
Other developers,

The new patch is ready but I have some hesitation in committing this changes. The reasons
are:

1) The # of test grows from 1300s to 2200s tests and 149 more test classes. (Not a good reason
for not committing)
2) The concern is the run duration for the mvn "test" target has grown approximately from
35 minutes to over 80 minutes on my Thinkpad. 
3) If the new tests provide value in validating openjpa functions, that is great but these
tests are just ran, mostly failed but ignored, then I am not too thrill in committing this
change.

Please reply and vote if you think it is worth to make the changes:
+1 - commit
0 - neutral
-1 - reject

Thanks,
Albert Lee.

> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
>                 Key: OPENJPA-770
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-770
>             Project: OpenJPA
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Michael Dick
>            Assignee: Tim McConnell
>             Fix For: 2.0.0
>
>         Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, OPENJPA-770.patch
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of
hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the
"parent" JIRA issue. 
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
>                         <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
>                         <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
>                         <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
>                         <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message