openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-896) Several doc files include Windows EoL chars
Date Fri, 27 Feb 2009 15:15:12 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677388#action_12677388
] 

Michael Dick commented on OPENJPA-896:
--------------------------------------

Per Don's email to the dev mailing list several java files also contain windows eol characters.
Unless someone disagrees I think we should use a single JIRA issue to resolve both problems.


I'm not sure why I don't see the problem when running svn diff on linux, but I see how this
can be a pain for those who do.

Proposed solution execute these commands on all .xml, .java files in the source tree
  svn propset  svn:eol-style native 
  dos2unix

Per conversation on the dev mailing list this is acceptable provided we do it in a single
big commit (ie no functional changes).

If this approach is not sufficient or anyone disagrees that we should do this please comment
here. 

> Several doc files include Windows EoL chars
> -------------------------------------------
>
>                 Key: OPENJPA-896
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-896
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: docs
>    Affects Versions: 1.0.3, 1.1.0, 1.2.0
>            Reporter: Donald Woods
>            Priority: Trivial
>             Fix For: 1.0.4, 1.2.1, 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-896-trunk-withprops.patch, OPENJPA-896-trunk.patch
>
>
> Several of the doc files include the Windows Ctrl+M chars at the end of lines when checked
out to non-Windows platforms (like MacOSX and Linux), due to the committer not using the ASF
suggested svn config values - http://www.apache.org/dev/svn-eol-style.txt
> From http://www.apache.org/dev/version-control.html -
> Configuring the Subversion client
> Committers will need to properly configure their svn client. One particular issue is
OS-specific line-endings for text files. When you add a new text file, especially when applying
patches from Bugzilla, first ensure that the line-endings are appropriate for your system,
then do ...
> svn add test.txt
> svn propset svn:eol-style native test.txt
> Your svn client can be configured to do that automatically for some common file types.
Add the contents of the file http://www.apache.org/dev/svn-eol-style.txt to your ~/.subversion/config
file. [Note: for Windows this is normally found at C:\Documents and Settings\{username}\Application
Data\Subversion\config]
> Some files may need additional properties to be set, for example svn:executable=* should
be applied to those script files (e.g. .bat, .cgi, .cmd, .sh) that are intended to be executed.
Since not all such files are necessarily intended to be executed, the executable property
should not be made an automatic default.
> However, you should still pay attention to the messages from your svn client when you
do 'svn commit'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message