openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim McConnell (JIRA)" <j...@apache.org>
Subject [jira] Updated: (OPENJPA-770) Use annotations instead of excluding tests in pom.xml
Date Tue, 03 Feb 2009 06:13:59 GMT

     [ https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim McConnell updated OPENJPA-770:
----------------------------------

    Attachment: OPENJPA-770.patch

Hi, I've attached a patch for this JIRA for review, comments, and hopefully inclusion. Please
consider these points when reviewing the patch: 

1. The @AllowFailure annotation was added (almost exclusively at the method level) to the
testcases that were previously excluded in the pom.xml.

2. Some of the testcases that were previously excluded in the pom.xml are now working, in
which case I did not alter them

3. Some testcases were repaired for other reasons. Most notably, testcases were repaired so
as not to fail the build (e.g., NullPointerExceptions were fixed, and testcases with no tests
were repaired).

4. Finally, I re-ordered all the imports in the classes that I touched, but I decided not
to include those changes in the patch so as not to confuse the reviewer. I can easily attach
that patch though if it would not be frowned upon. 

> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
>                 Key: OPENJPA-770
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-770
>             Project: OpenJPA
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Michael Dick
>            Assignee: Tim McConnell
>             Fix For: 2.0.0
>
>         Attachments: OPENJPA-770.patch
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases. Instead of
hard coding these in pom.xml we should use the new annotation that Pinaki introduced in the
"parent" JIRA issue. 
> The list of excluded tests can be found in pom.xml, here's a subsection of them
> <!-- exclude new tests that aren't passing yet -->
>                         <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
>                         <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
>                         <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
>                         <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message