openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick" <michael.d.d...@gmail.com>
Subject Re: [VOTE] Approve OpenJPA 1.2.0 release
Date Mon, 11 Aug 2008 17:15:02 GMT
With the exception of increasing the download size I don't think the .java
or .html files (javadoc) are causing a "problem" with openjpa jar file.

In fact I suspect they're helpful when developing applications - ie just add
the single jar to [insert your favorite IDE here]'s classpath. I think many
IDEs can find the source / javadoc if it's included in the jar. Some might
require explicit configuration, but at least you have it.

I think the most correct option is to provide an openjpa-1.2.0-sources.jar
and openjpa-1.2.0-javadoc.jar in the maven repository. For the official
downloads I think we can choose to include the source with the binaries.

Having the source included is an unintended side effect of creating the
openjpa-xxx-sources.jar and openjpa-xxx-javadoc.jar files (the source and
javadoc plugins respectively) and the openjpa-all module's mechanism for
producing an aggregate jar.

In order to remove the source and javadoc files from the archive just apply
a patch like this one.
Index: openjpa-all/pom.xml
===================================================================
--- openjpa-all/pom.xml    (revision 681725)
+++ openjpa-all/pom.xml    (working copy)
@@ -53,6 +53,8 @@
                                     <fileset dir="${basedir}/..">
                                         <include
name="*/target/openjpa-*.jar" />
                                         <exclude
name="*/target/openjpa-examples-*.jar" />
+                                        <exclude name="**/*.java"/>
+                                        <exlucde name="**/*.html"/>
                                     </fileset>
                                 </unjar>

This patch is a bit of a hack. We might be better suited to use the assembly
plugin to generate the aggregate jar and configure it to exclude sources and
javadoc.

IMHO the additional files do not invalidate the release, functionally we
should be covered, however I respect Kevin's right to disagree. If the -1
vote stands consider this vote officially rescinded and we can start over.

Sadly, I have broken the cardinal rule for release managers and I'm out of
the country with limited Internet access for quite a while. If this vote
does not pass I will step down as the release manager at least until I get
back in September.

-mike

On Mon, Aug 11, 2008 at 3:15 PM, Pinaki Poddar <ppoddar@apache.org> wrote:

>
> The embedded openjpa.jar is indeed bloated with Java source files.
>
>
> Kevin Sutter wrote:
> >
> > Might have found a problem with the new maven release plugin.  The binary
> > archive
> > (apache-openjpa-1.2.0-binary.zip<
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-binary.zip
> >)
> > seems to be about 8M larger than the previous 1.1.0 release.  The culprit
> > seems to be the embedded openjpa-1.2.0.jar file, which seems to include
> > the
> > java source files.
> >
> > I have been attempting to reproduce the situation using the new release
> > process, but I'm hitting a couple of problems with gpg key processing.
> >
> > Unless someone can convince me that this latest packaging is "okay", I
> > will
> > have to vote -1.
> >
> > Kevin
> >
> >
> >
> > On Wed, Aug 6, 2008 at 8:27 PM, Michael Dick
> > <michael.d.dick@gmail.com>wrote:
> >
> >> OpenJPA Developers,
> >>
> >> A second candidate build for OpenJPA 1.2.0 is available on
> >> http://people.apache.org/~mikedd <http://people.apache.org/%7Emikedd>
<
> http://people.apache.org/%7Emikedd> <
> >> http://people.apache.org/%7Emikedd> in the
> >> following locations.
> >>
> >> Source archive:
> >>
> >>
> http://people.apache.org/~mikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-source.zip<http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-source.zip>
> <
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-source.zip
> >
> >> <
> >>
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-source.zip
> >> >
> >> Binary archive:
> >>
> >>
> http://people.apache.org/~mikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-binary.zip<http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-binary.zip>
> <
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-binary.zip
> >
> >> <
> >>
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/apache-openjpa-1.2.0-binary.zip
> >> >
> >> *GPG signatures and checksums (MD5 and SHA1) can be found in the parent
> >> directory:
> >>
> >>
> http://people.apache.org/~mikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/<http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/>
> <
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/
> >
> >> <
> >>
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/org/apache/openjpa/apache-openjpa/1.2.0/
> >> >
> >>
> >> Documentation has also been published in the following locations.
> >> Manual :
> >>
> >>
> http://people.apache.org/~mikedd/openjpa/1.2.0/staging-site/apache-openjpa-1.2.0/docs/manual/<http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-site/apache-openjpa-1.2.0/docs/manual/>
> <
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-site/apache-openjpa-1.2.0/docs/manual/
> >
> >> <
> >>
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-site/apache-openjpa-1.2.0/docs/manual/
> >> >
> >> Javadoc :
> >>
> http://people.apache.org/~mikedd/openjpa/1.2.0/staging-site/docs/javadoc/<http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-site/docs/javadoc/>
> <
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-site/docs/javadoc/
> >
> >> <
> >>
> http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-site/docs/javadoc/
> >> >
> >> Release Notes :
> >>
> >>
> http://svn.apache.org/viewvc/openjpa/tags/1.2.0/openjpa-project/RELEASE-NOTES.html?revision=677734&view=markup
> >>
> >> In addition maven artifacts have been published to a staging repository
> >> on
> >> people.apache.org. You may use the staging repository by adding the
> >> following information in pom.xml :
> >>    <repositories>
> >>        . . .
> >>        <repository>
> >>            <id>OpenJPA 1.2.0 staging repository</id>
> >>            <name>OpenJPA 1.2.0 staging repository</name>
> >>            <url>
> >>
> >> http://people.apache.org/~mikedd/openjpa/1.2.0/staging-repo/<http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/>
> <http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/>
> >> <http://people.apache.org/%7Emikedd/openjpa/1.2.0/staging-repo/>
> >>
> >>            </url>
> >>        </repository>
> >>    </repositories>
> >>        . . .
> >>    <dependencies>
> >>        . . .
> >>        <dependency>
> >>            <groupId>org.apache.openjpa</groupId>
> >>            <artifactId>openjpa</artifactId>
> >>            <version>1.2.0</version>
> >>        </dependency>
> >>    </dependencies>
> >>
> >> The Release Audit Tool maven plugin was executed with the build
> candidate
> >> and no problems were found.
> >>
> >> Please vote to publish this incubating release on the project Web page:
> >> http://cwiki.apache.org/openjpa/downloads.html
> >>
> >> This vote will remain open until 9:00 AM CDT Monday August 11, 2008. A
> >> "+1"
> >> indicates that you approve of the release, a "-1" indicates a vote
> >> against
> >> making a release.
> >>
> >> Thanks in advance for your help in ratifying this release!
> >>
> >>  -Michael Dick
> >>
> >
> >
>
> --
> View this message in context:
> http://n2.nabble.com/-VOTE--Approve-OpenJPA-1.2.0-release-tp677449p686000.html
> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message