Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 31181 invoked from network); 30 Jul 2008 14:55:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Jul 2008 14:55:52 -0000 Received: (qmail 18269 invoked by uid 500); 30 Jul 2008 14:55:52 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 18233 invoked by uid 500); 30 Jul 2008 14:55:51 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 18222 invoked by uid 99); 30 Jul 2008 14:55:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jul 2008 07:55:51 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jul 2008 14:55:05 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D1E79234C199 for ; Wed, 30 Jul 2008 07:55:31 -0700 (PDT) Message-ID: <439386941.1217429731858.JavaMail.jira@brutus> Date: Wed, 30 Jul 2008 07:55:31 -0700 (PDT) From: "Jeremy Bauer (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Updated: (OPENJPA-670) Discriminator column is missing from table when inheritance is used without annotation In-Reply-To: <1808189801.1217365651657.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Bauer updated OPENJPA-670: --------------------------------- Attachment: openjpa-670.patch Attaching patch containing fix and jUnits for trunk (currently 1.3.0). Please review and if no comments, commit for trunk and 1.2.x. In case it isn't clear from the code and comments, the update to PersistenceTestCase is to clean up tables used by managed interfaces. They are by definition abstract and were being skipped during the cleanup process. > Discriminator column is missing from table when inheritance is used without annotation > -------------------------------------------------------------------------------------- > > Key: OPENJPA-670 > URL: https://issues.apache.org/jira/browse/OPENJPA-670 > Project: OpenJPA > Issue Type: Bug > Components: jdbc > Affects Versions: 1.2.0, 1.3.0 > Reporter: Jeremy Bauer > Attachments: openjpa-670.patch > > > According to the EJB 3.0 JPA spec (pp. 191, section 9.1.29): > "If the Inheritance annotation is not specified or if no inheritance type is specified for an entity class > hierarchy, the SINGLE_TABLE mapping strategy is used." > I've found that if an entity inheritance hierarchy is specified without an explicit DiscriminatorColumn or Inheritance annotation, a single table will be used for mapping, but there will be no discriminator column in the table. > pp. 191 - 192, section 9.1.30 of the spec reads: > "For the SINGLE_TABLE mapping strategy, and typically also for the JOINED strategy, the persistence > provider will use a type discriminator column." > and > "If the DiscriminatorColumn annotation is missing, and a discriminator column is required, the > name of the discriminator column defaults to "DTYPE" and the discriminator type to STRING." > Without a discriminator column a scenario such as: > entity B extends entity A > entity C extends entity A > "select c from C" will return entities of type A, B, and C (which is a data integrity issue) because there is no way to distinguish between the entity types. > The simple workaround is to specify an @Inheritance or @DiscriminatorColumn annotation on the root class, but OpenJPA should exhibit default behavior defined by the spec when these annotations are not specified. > I have a patch and jUnits in the works and will post them shortly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.