Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: domain of
 lists+1214986235816-210739@n2.nabble.com designates 216.139.236.158 as
 permitted sender)
Message-ID: <1216135898473-529211.post@n2.nabble.com>
Date: Tue, 15 Jul 2008 08:31:38 -0700 (PDT)
From: Pinaki Poddar <ppoddar@apache.org>
To: dev@openjpa.apache.org
Subject: Re: svn commit: r676604 -
 /openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/StateManagerImpl.java
In-Reply-To: <4CBF0A1B-344C-4819-B204-2934570CB397@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
References: <81C8A74F-4EB5-40CD-80AB-B4DD0FDAFEEA@gmail.com>
 <1216058504459-527694.post@n2.nabble.com>
 <4CBF0A1B-344C-4819-B204-2934570CB397@gmail.com>


The change was initiated by a JIRA report OPENJPA-659. 
The failure was observed for runtime enhanced instances during dirty
checking. Dirty checking for untracked instances is skipped under certain
conditions. My initial attempt was to expand that condition to skip
non-transactional instances too. However, that was not a correct move as
other TeamCity tests started complaining. And hence the rollback of the
change.

On some more digging, first thing found was that the artifacts of the
reported scenario of embedded field, Spring-Tomcat-Weaver are *not* crucial
factors and the same error can be reproduced at a simpler setup as newly
added TestSimpleUnenhancedQuery demonstrates. The reason is a
SaveFieldManager was being constructed only if the invoked StateManager had
loaded fields. When the call to saveFields were made during StateManager
initialization, there was no field loaded and hence no SaveFieldManager.
This led to subsequent failure during dirty check.

It has now been corrected (refer OPENJPA-659 for details). But please review
and verify my explanation. 
 

-- 
View this message in context: http://n2.nabble.com/Re%3A-svn-commit%3A-r676604----openjpa-trunk-openjpa-kernel-src-main-java-org-apache-openjpa-kernel-StateManagerImpl.java-tp527508p529211.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.