From dev-return-8632-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Tue Jul 15 14:51:15 2008 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 69990 invoked from network); 15 Jul 2008 14:51:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Jul 2008 14:51:15 -0000 Received: (qmail 9410 invoked by uid 500); 15 Jul 2008 14:51:15 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 9237 invoked by uid 500); 15 Jul 2008 14:51:14 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 9226 invoked by uid 99); 15 Jul 2008 14:51:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2008 07:51:14 -0700 X-ASF-Spam-Status: No, hits=1.7 required=10.0 tests=SPF_PASS,WEIRD_PORT,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of plinskey@gmail.com designates 209.85.132.241 as permitted sender) Received: from [209.85.132.241] (HELO an-out-0708.google.com) (209.85.132.241) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2008 14:50:17 +0000 Received: by an-out-0708.google.com with SMTP id c36so1118529ana.96 for ; Tue, 15 Jul 2008 07:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=TRem6ZZCFhdlFvRPUNEDUfqTqj8n9cAg2FYxPkv2ZuQ=; b=FmZcUE4sLqX5cs8l+msiAHEmSX1lxPQDpO/Aky6wUoG4wPlCuIRG1OCQoW4lQQ2bkz P1MCtk9MbHhufi6gu+FP6dVx/dGptfScmJgbcB+q4dpxiFiO1tId+ONhTp+ZesmNfOa8 1Eb7M299VL3P3E2Q8OziJcYtP6oSr3gGd4mK0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=LsrZ+gHwm2SI2Y9jZsdPT+rPE2Kh4FMbjLmlD+qD77bgqBfh9Khl5Nk3XD7TKAUZM7 77rOTbFofpi83+U9vCwN9Ni4FYQHNGzJu9zxft+HBVgvmfIRSmOogZN26ISYslWaWI6q j5rCE90TyrLpbQX67VHQ9cAFmVNlV53nQp6Jk= Received: by 10.100.47.13 with SMTP id u13mr11509266anu.56.1216133440032; Tue, 15 Jul 2008 07:50:40 -0700 (PDT) Received: from ?192.168.0.195? ( [75.54.95.100]) by mx.google.com with ESMTPS id 27sm6334916wra.32.2008.07.15.07.50.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 15 Jul 2008 07:50:39 -0700 (PDT) Message-Id: <4CBF0A1B-344C-4819-B204-2934570CB397@gmail.com> From: Patrick Linskey To: dev@openjpa.apache.org In-Reply-To: <1216058504459-527694.post@n2.nabble.com> Content-Type: multipart/signed; boundary=Apple-Mail-19--544447581; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v926) Subject: Re: svn commit: r676604 - /openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/StateManagerImpl.java Date: Tue, 15 Jul 2008 09:50:37 -0500 References: <81C8A74F-4EB5-40CD-80AB-B4DD0FDAFEEA@gmail.com> <1216058504459-527694.post@n2.nabble.com> X-Mailer: Apple Mail (2.926) X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-19--544447581 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit What was the goal of the original change? OpenJPA has a concept of non- managed fields; that might suit your needs. -Patrick On Jul 14, 2008, at 1:01 PM, Pinaki Poddar wrote: > > I have backed out the change. > r676642 | ppoddar | 2008-07-14 11:54:05 -0500 (Mon, 14 Jul 2008) | 1 > line > > Revert changes to exclude non-transactional states from dirty checking > ------------------------------------------------------------------------ > r676604 | ppoddar | 2008-07-14 09:33:59 -0500 (Mon, 14 Jul 2008) | 1 > line > > Skip dirty check for nontransactional, runtime-enhanced instances > > Monitoring a TeamCity test to see if the backout restores the > no-test-failed. > > > > Patrick Linskey-2 wrote: >> >> Hi, >> >> It looks like this checkin broke some tests. >> >> In related news, http://openjpa-teamcity.dyndns.org:8111 is back up, >> but I need to recreate accounts for those who are interested in them. >> So, if you want one, let me know. >> >> -Patrick >> >> On Jul 14, 2008, at 7:34 AM, ppoddar@apache.org wrote: >> >>> Author: ppoddar >>> Date: Mon Jul 14 07:33:59 2008 >>> New Revision: 676604 >>> >>> URL: http://svn.apache.org/viewvc?rev=676604&view=rev >>> Log: >>> Skip dirty check for nontransactional, runtime-enhanced instances >>> >>> Modified: >>> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/ >>> kernel/StateManagerImpl.java >>> >>> Modified: openjpa/trunk/openjpa-kernel/src/main/java/org/apache/ >>> openjpa/kernel/StateManagerImpl.java >>> URL: >>> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/StateManagerImpl.java?rev=676604&r1=676603&r2=676604&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/ >>> kernel/StateManagerImpl.java (original) >>> +++ openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/ >>> kernel/StateManagerImpl.java Mon Jul 14 07:33:59 2008 >>> @@ -811,7 +811,7 @@ >>> public void dirtyCheck() { >>> if (!needsDirtyCheck()) >>> return; >>> - >>> + >>> SaveFieldManager saved = getSaveFieldManager(); >>> if (saved == null) >>> throw new InternalException(_loc.get("no-saved-fields", >>> @@ -837,6 +837,8 @@ >>> return false; >>> if (isNew() && !isFlushed()) >>> return false; >>> + if (!isTransactional()) >>> + return false; >>> return true; >>> } >>> >>> >>> >> >> -- >> Patrick Linskey >> 202 669 5907 >> >> >> >> > > -- > View this message in context: http://n2.nabble.com/Re%3A-svn-commit%3A-r676604----openjpa-trunk-openjpa-kernel-src-main-java-org-apache-openjpa-kernel-StateManagerImpl.java-tp527508p527694.html > Sent from the OpenJPA Developers mailing list archive at Nabble.com. > -- Patrick Linskey 202 669 5907 --Apple-Mail-19--544447581 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGQjCCAvsw ggJkoAMCAQICEFRl2XJqdL0MfVy/DuLjrLcwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MDUyMjE2MDgzOVoXDTA5MDUyMjE2MDgz OVowYTEQMA4GA1UEBBMHTGluc2tleTEQMA4GA1UEKhMHUGF0cmljazEYMBYGA1UEAxMPUGF0cmlj ayBMaW5za2V5MSEwHwYJKoZIhvcNAQkBFhJwbGluc2tleUBnbWFpbC5jb20wggEiMA0GCSqGSIb3 DQEBAQUAA4IBDwAwggEKAoIBAQC81WdJi9HJVS4Hq8IDULst5M9aVkb15B4TDWHAkv4DTScEY7xZ tt+q1Tey67VqlR+9vrbKegipVrjDhCuQ9vCpWyS9PGL8OZgM8dVe6iIeYpcaEovyde3ocEjQxjJI PbCtLMZrCj2YUlPPTvcDljTxDqCWas0Ivo8wbMt4ZY/EmnpgCcQJRHjbYzC1hcUGP6Au8gE0JkHl k32C5ocrENtLk8UzVzZ7tyIbZKgY0S2p9OsfOJV4hPIqiNjDiZ1Npa8YWpKUcTor5D0+CaIGnvnH D3uQuslOjKksmbP3sE/4iZ1R/IY7qG2oAbFJOG+3SO3/9G3VGi5fPhYRCTkavm8ZAgMBAAGjLzAt MB0GA1UdEQQWMBSBEnBsaW5za2V5QGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEB BQUAA4GBAEdHhGUDnvAq5tA7lQ3JCOF4F+8filVOkEPl/iyMmZTQ6+eHTZPPyA22eV6HPGWsHmwN MwiS+/7mk87+Gw+jNHSPuNLeAsr/bDrL9SEwyT5eQXMVu4I36MCiZpsHdzz9PPyxDq6o6entgJ/A /LgpuI+GV5VTWbmg4HilLnusR9I9MIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TEL MAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRow GAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNl cyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZI hvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEz MDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGf MA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Ia dr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+ K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1Ud EwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1Ro YXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRow GAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2as Zw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCU YsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9l TzGCAxAwggMMAgEBMHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5n IChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENB AhBUZdlyanS9DH1cvw7i46y3MAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0B BwEwHAYJKoZIhvcNAQkFMQ8XDTA4MDcxNTE0NTAzN1owIwYJKoZIhvcNAQkEMRYEFFxkVCD1DlvP Dj1DplsF3eRMEI9hMIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxU aGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJl ZW1haWwgSXNzdWluZyBDQQIQVGXZcmp0vQx9XL8O4uOstzCBhwYLKoZIhvcNAQkQAgsxeKB2MGIx CzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYD VQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQVGXZcmp0vQx9XL8O4uOs tzANBgkqhkiG9w0BAQEFAASCAQCXnprUPFJyPHGp7X7dvXeK4nwPid4raCKqE9eaZu798jJZZy6h DW2sbqxuYtHV+6MX2X2pG5Y9iSMrIQal19nC9wpDrFV+tR1axv/gS2/dLMoYIF34jpRQn+d4o0mt yLh4nMYRndu4PVpnmaNL9MAWLQ7qzDGnOOUl0CV4yC4ALdBSMYfhqk3KQer5Dc2wstRLLcYdykX2 WBunEoHqTnBJPeimrsZorXfzIsYvMf4U8zcErCOyEjPa/WQqBvvOBwqXxYb24f9NWa5AN2pvEfsA +PfR+jSDtbpOVJ1d8HrGKZH+KKENE5QqlwaAhag+rfSsy7dudTZrt7c9X3AXihZ5AAAAAAAA --Apple-Mail-19--544447581--