From dev-return-8164-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Mon May 19 18:05:36 2008 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 33933 invoked from network); 19 May 2008 18:05:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 May 2008 18:05:36 -0000 Received: (qmail 82656 invoked by uid 500); 19 May 2008 18:05:37 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 82623 invoked by uid 500); 19 May 2008 18:05:37 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 82610 invoked by uid 99); 19 May 2008 18:05:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2008 11:05:37 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of plinskey@gmail.com designates 209.85.200.174 as permitted sender) Received: from [209.85.200.174] (HELO wf-out-1314.google.com) (209.85.200.174) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2008 18:04:50 +0000 Received: by wf-out-1314.google.com with SMTP id 28so1545599wfc.24 for ; Mon, 19 May 2008 11:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer; bh=vGUh1hmiROBYhXU2xJA6lV/VFHM2mmKaKYIlAdNROtw=; b=qNqnbGWweYH/4oQFGmDPgqKDIpnNhr7vz9Xaq9XfvazwuREKPsEuYg1mbSbrjT7UW2QpQyzwtVAuYHeCaGv55DrDOcbDY6gF81FzHvw0pLFuE/Je/e7Fvdvre2+/LLDGdZZsqo247UlSDoElj5jOYhhFqzvDMBNf8VztiHEijIQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer; b=OLUX2IdCwEaW40IzIYIBAVasdcArBe0G6zY5bv7JA0lYbxt8pnX7SNMp14tgvM/RI2h2Sjec/NykTi/rXQ+8428gLqNXY3IRdLQTY9NI45GIFDeUqLUaPZ9hhFUiEvMkkij1XSuLCU/NVsfjslGBEApEKNsb/gsO/KpXaLCQhDU= Received: by 10.142.103.11 with SMTP id a11mr2950235wfc.273.1211220305843; Mon, 19 May 2008 11:05:05 -0700 (PDT) Received: from ?192.168.1.118? ( [67.180.113.155]) by mx.google.com with ESMTPS id 28sm18017904wfg.15.2008.05.19.11.05.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 19 May 2008 11:05:05 -0700 (PDT) Message-Id: <5075D6F0-AC1A-4549-9DA8-B03418A3B6E8@gmail.com> From: Patrick Linskey To: dev@openjpa.apache.org In-Reply-To: <72c1350f0805190919g3f24cc3fsfd5f553a72a70639@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Subject: Re: SerialVersionUIDs Date: Mon, 19 May 2008 11:05:00 -0700 References: <72c1350f0805190919g3f24cc3fsfd5f553a72a70639@mail.gmail.com> X-Mailer: Apple Mail (2.919.2) X-Virus-Checked: Checked by ClamAV on apache.org Let's fix it and rebuild a release. Interop is a good thing. Do we have any tests that demonstrate and enforce serialization compatibility across versions? It seems like if we are interested in making interop guarantees, then we should come up with some test cases that we can rely on moving forward. -Patrick On May 19, 2008, at 9:19 AM, Michael Dick wrote: > Earlier today I changed the serialVersionUIDs for > DetachedStateManager in > trunk and the 1.0.x branch. > > At the time I thought that those were the only branches where we > specified > the UID, but it looks like it's present in the 1.1.x branch as well. > the > 1.1.x branch can certainly be updated as well, but with 1.1.0 nearly > out the > door it's a little late to make the change. > > The original problem was that we encountered an inconsistent > serialVersionUID, depending on the JVM (OPENJPA-559). In that JIRA a > serialUID was added, but it was based on version from trunk, not the > version > found in 1.0.x. > > As a result we were compatible between JVMs but not between releases > ie if > you serialized a DetachedStateManager on version 1.0.2 or 1.0.1 it > could not > be deserialized on 1.2.x. Switching the value to the one that was > generated > on 1.0.2 allows the deserialization to work. We've changed a method > name > (throwing off the generated serial uid) but it doesn't appear to be an > incompatible change (ie no fields were removed etc). > > Since the original change was made to the 1.1.x branch we either > need to > hold up 1.1.0 and update its copy or undo this morning's changes > and deal > with a break in compatibility between 1.0.2 and 1.0.3 and onward. > > Does anyone have a strong preference? > > > -mike -- Patrick Linskey 202 669 5907