openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Albert Lee (JIRA)" <>
Subject [jira] Commented: (OPENJPA-604) Log spec sets in persistence unit's property fail with exception when run in different locale
Date Tue, 20 May 2008 15:58:55 GMT


Albert Lee commented on OPENJPA-604:

I have the same feeling at the first glance and it was also my first choice. 

After some thought, I was worried about if there is any existing application that actually
uses locale specific Log spec in their p.xml or Map passed to createEntityManager[Factory],
option 1 will break their application. Option 2 is a compromise to avoid any back compatibility
breakage but still support option 1, which is the preferred behavior.

If there are any strong opinions that backward compatibility is NOT a concern, I can go for
option 1.

Albert Lee.

> Log spec sets in persistence unit's property fail with exception when run in different
> ---------------------------------------------------------------------------------------------
>                 Key: OPENJPA-604
>                 URL:
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: lib
>    Affects Versions: 1.0.3, 1.1.0, 1.2.0
>            Reporter: Albert Lee
>            Assignee: Albert Lee
>            Priority: Minor
>             Fix For: 1.2.0
> When an application sets the Log property in a persistence unit (persistence.xml) or
passes in through map during createEntityManager[Factory] using one locale,  this setting
will fail when runs in a different locale.
> It is caused by the LogImpl:
> 1) retrieve the *_STR from the
>     public static final String TRACE_STR = _loc.get("log-trace").getMessage();
>     public static final String INFO_STR = _loc.get("log-info").getMessage();
>     public static final String WARN_STR = _loc.get("log-warn").getMessage();
>     public static final String ERROR_STR = _loc.get("log-error").getMessage();
>     public static final String FATAL_STR = _loc.get("log-fatal").getMessage();
> 2) compare only the current locale *_STR values;
>     public static short getLevel(String str) {
>         str = str.toUpperCase().trim();
>         short val = TRACE_STR.equals(str) ? Log.TRACE :
>             INFO_STR.equals(str) ? Log.INFO :
>                 WARN_STR.equals(str) ? Log.WARN :
>                     ERROR_STR.equals(str) ? Log.ERROR :
>                         FATAL_STR.equals(str) ? Log.FATAL : -1;
>         if (val == -1)
>             throw new IllegalArgumentException
>                 (_loc.get("log-bad-constant", str).getMessage());
>         return val;
>     }
> I understand the intention is to match the Log setting using the same locale, however
if the Log string is set in an application's persistence unit (persistence.xml) or business
logic (createEntityManagerFactory( ...., map)), the application will fail.
> I see two alternatives:
> 1) Since Log is part of the property and configuration framework, none of these property
settings are local sensitive.  We can make Log property NOT locale sensitive, i.e. always
use TRACE, INFO, WARN, ERROR and FATAL as the Log values.
> 2) Access both English (as in alternative 1) and also whatever current locale Log values.
I.e. English only Log values will work when set in persistence.xml and business logic  regardless
of the current locale setting but locale specific settings ONLY work in the same current locale.
> Personally, the second option is more attractive and also backward compatible with existing
application that uses locale specific behavior.
> Please comment on your preference!
> Albert Lee.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message