openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Linskey" <plins...@gmail.com>
Subject Re: comments about DataCacheStoreManager.transformToVersionSafePCDatas()
Date Fri, 04 Apr 2008 06:35:14 GMT
>  The DataCacheStoreManager.transformToVersionSafePCDatas()  line 261. This
>  method should call either cache.containsAll() or cache.getAll(). The
>  current implementation makes one call to the cache for each element in the
>  collection.

It would be easier to refactor this if DataCache.getAll() took a
Collection as an argument instead of a List. I know that DataCache is
implemented separately at IBM; how is that done? I'm wondering what
the impact of changing the signature of getAll() would be.

-Patrick

On Thu, Apr 3, 2008 at 10:48 AM,  <Frederic_Bellier@capgroup.com> wrote:
>
>
>  The DataCacheStoreManager.transformToVersionSafePCDatas()  line 261. This
>  method should call either cache.containsAll() or cache.getAll(). The
>  current implementation makes one call to the cache for each element in the
>  collection.
>
>
>  The AbstractDataCache.putAllInternal() method suffers from the same issues.
>  This is OK becuase it can be overwritten in a plugin. But I am thinking
>  that maybe someone from the openjpa developer community might want to fix
>  that in there too. That way the base class could actually be used as a base
>  class to write other L2 cache plugins.
>
>  F
>
>



-- 
Patrick Linskey
202 669 5907

Mime
View raw message