From dev-return-7631-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org Tue Mar 18 01:32:14 2008 Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 85534 invoked from network); 18 Mar 2008 01:32:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Mar 2008 01:32:14 -0000 Received: (qmail 70021 invoked by uid 500); 18 Mar 2008 01:32:12 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 69999 invoked by uid 500); 18 Mar 2008 01:32:12 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 69990 invoked by uid 99); 18 Mar 2008 01:32:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2008 18:32:12 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2008 01:31:30 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C9FDC234C0A5 for ; Mon, 17 Mar 2008 18:30:25 -0700 (PDT) Message-ID: <1283748879.1205803825826.JavaMail.jira@brutus> Date: Mon, 17 Mar 2008 18:30:25 -0700 (PDT) From: "Kevin Sutter (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Commented: (OPENJPA-538) In the case when user id and password are provided, openjpa should use them in the call to getConnection to avoid "Null userid is not supported" thrown from the backend. In-Reply-To: <1443261029.1205789426682.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579699#action_12579699 ] Kevin Sutter commented on OPENJPA-538: -------------------------------------- Fay, Although the attached patch probably resolves the problem, the code is not consistent with the javadoc. According to the javadoc, the call to getDataSource2 should resolve to the right username and password. If that's not working as expected, then we should fix that problem. Here's the javadoc for getDataSource2: DataSource org.apache.openjpa.jdbc.conf.JDBCConfiguration.getDataSource2(StoreContext ctx) Return the non-enlisted data source to use. If there is a valid non-xa connection factory configured, then it will be returned. Its default user name and password on calls to DataSource.getConnection will be the specificed connection 2 user name and password. If those are null and the given context is non-null, its user name password will be used instead. If the context is null too, then the user name and password used to retrieve the first context will be used. If there is no second connection factory the primary connection factory is used. Thanks, Kevin > In the case when user id and password are provided, openjpa should use them in the call to getConnection to avoid "Null userid is not supported" thrown from the backend. > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: OPENJPA-538 > URL: https://issues.apache.org/jira/browse/OPENJPA-538 > Project: OpenJPA > Issue Type: Bug > Components: jdbc > Affects Versions: 1.1.0 > Reporter: Fay Wang > Fix For: 1.1.0 > > Attachments: OPENJPA-538.637439.patch > > > [jcc][t4][10205][11234][3.51.74] Null userid is not supported. ERRORCODE=-4461, SQLSTATE=42815 > org.apache.openjpa.jdbc.sql.SQLExceptions.narrow(SQLExceptions.java:146) > org.apache.openjpa.jdbc.sql.DBDictionary.newStoreException(DBDictionary.java:4054) > org.apache.openjpa.jdbc.sql.DB2Dictionary.newStoreException(DB2Dictionary.java:501) > org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:102) > org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:80) > org.apache.openjpa.jdbc.kernel.TableJDBCSeq.allocateSequence(TableJDBCSeq.java:402) > org.apache.openjpa.jdbc.kernel.TableJDBCSeq.nextInternal(TableJDBCSeq.java:266) > org.apache.openjpa.jdbc.kernel.AbstractJDBCSeq.next(AbstractJDBCSeq.java:60) > org.apache.openjpa.util.ImplHelper.generateValue(ImplHelper.java:160) > org.apache.openjpa.util.ImplHelper.generateFieldValue(ImplHelper.java:144) > org.apache.openjpa.jdbc.kernel.JDBCStoreManager.assignField(JDBCStoreManager.java:592) > org.apache.openjpa.util.ApplicationIds.assign(ApplicationIds.java:464) > org.apache.openjpa.util.ApplicationIds.assign(ApplicationIds.java:440) > org.apache.openjpa.jdbc.kernel.JDBCStoreManager.assignObjectId(JDBCStoreManager.java:576) > org.apache.openjpa.kernel.DelegatingStoreManager.assignObjectId(DelegatingStoreManager.java:134) > org.apache.openjpa.kernel.StateManagerImpl.assignObjectId(StateManagerImpl.java:517) > org.apache.openjpa.kernel.StateManagerImpl.preFlush(StateManagerImpl.java:2814) > org.apache.openjpa.kernel.PNewState.beforeFlush(PNewState.java:39) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.