Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: domain of kwsutter@gmail.com designates
 209.85.146.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=AOYdAAxEYKal8eBf7pj3QL5nVSmqVE16hmjbjHqd2tKuvIxAbUH+3ABXr/kVKsVAwgJjP3alvRNp0q4ehGBk+cRtvNsrI0SfsnfVP6EDu3z/j0gUy//b9DgFkSdAg9RPMBs7dLEGA5EVdNp+ZwHhO/zePqVOsoTjJQCp5b13vfU=
Message-ID: <89c0c52c0802221111o4fa1adc6rfee822f87cc1f5e9@mail.gmail.com>
Date: Fri, 22 Feb 2008 13:11:57 -0600
From: "Kevin Sutter" <kwsutter@gmail.com>
To: dev@openjpa.apache.org
Subject: Re: svn commit: r629845 -
 /openjpa/branches/1.0.x/openjpa-persistence-jdbc/src/test/resources/META-INF/listener-orm.xml
In-Reply-To: <7262f25e0802220759y2086282ct7dc6c79e9075a5af@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_2192_9289267.1203707517448"
References: <20080221161023.9CFE71A9832@eris.apache.org>
	 <7262f25e0802220759y2086282ct7dc6c79e9075a5af@mail.gmail.com>

------=_Part_2192_9289267.1203707517448
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Patrick,
Part of the problem with OPENJPA-513 was that the Sun JDK sax parser is
running in non-validation mode per the _schemaBug flag in the
XMLMetaDataParser.  Thus, until I ran with the IBM JDK that uses a
validating parser, this listener-orm.xml file had syntax errors.  I
originally fixed just the 1.1.0 branch back on Feb 09.  I just recently
noticed that this same test case was active in the 1.0.x branch, so I ported
the changes back to that branch yesterday.

I didn't change the semantics of the test, I just put the xml elements in
the proper order to pass validation.  But, because of the proper ordering, I
had to fully qualify the location of the ListenerImpl since the <package>
declaration didn't apply to the <entity-listener> element.

Kevin

On Fri, Feb 22, 2008 at 9:59 AM, Patrick Linskey <plinskey@gmail.com> wrote:

> Hi,
>
> How is this related to OPENJPA-513? I believe that having the
> ListenerImpl defined in the persistence-unit-defaults is important for
> the semantics of the test.
>
> -Patrick
>
> On Thu, Feb 21, 2008 at 8:10 AM,  <kwsutter@apache.org> wrote:
> > Author: kwsutter
> >  Date: Thu Feb 21 08:10:22 2008
> >  New Revision: 629845
> >
> >  URL: http://svn.apache.org/viewvc?rev=629845&view=rev
> >  Log:
> >  OPENJPA-513.  Ported change back to 1.0.x release.
> >
> >  Modified:
> >
> openjpa/branches/1.0.x/openjpa-persistence-jdbc/src/test/resources/META-INF/listener-
> orm.xml
> >
> >  Modified:
> openjpa/branches/1.0.x/openjpa-persistence-jdbc/src/test/resources/META-INF/listener-
> orm.xml
> >  URL:
> http://svn.apache.org/viewvc/openjpa/branches/1.0.x/openjpa-persistence-jdbc/src/test/resources/META-INF/listener-orm.xml?rev=629845&r1=629844&r2=629845&view=diff
> >
>  ==============================================================================
> >  ---
> openjpa/branches/1.0.x/openjpa-persistence-jdbc/src/test/resources/META-INF/listener-
> orm.xml (original)
> >  +++
> openjpa/branches/1.0.x/openjpa-persistence-jdbc/src/test/resources/META-INF/listener-
> orm.xml Thu Feb 21 08:10:22 2008
> >  @@ -21,16 +21,17 @@
> >      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> >      xsi:schemaLocation="http://java.sun.com/xml/ns/persistence/ormorm_1_0.xsd"
> >      version="1.0">
> >  -    <package>org.apache.openjpa.persistence.callbacks</package>
> >  -    <entity class="EntityListenerEntity">
> >  -        <exclude-default-listeners>true</exclude-default-listeners>
> >  -    </entity>
> >      <persistence-unit-metadata>
> >          <persistence-unit-defaults>
> >              <entity-listeners>
> >  -                <entity-listener class="ListenerImpl">
> >  +                <entity-listener class=
> >  +                       "
> org.apache.openjpa.persistence.callbacks.ListenerImpl">
> >                  </entity-listener>
> >              </entity-listeners>
> >          </persistence-unit-defaults>
> >      </persistence-unit-metadata>
> >  +    <package>org.apache.openjpa.persistence.callbacks</package>
> >  +    <entity class="EntityListenerEntity">
> >  +        <exclude-default-listeners/>
> >  +    </entity>
> >   </entity-mappings>
> >
> >
> >
>
>
>
> --
> Patrick Linskey
> 202 669 5907
>

------=_Part_2192_9289267.1203707517448--