Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Thu, 07 Feb 2008 08:50:55 -0800
From: Craig L Russell <Craig.Russell@Sun.COM>
Subject: Re: Line endings
In-reply-to: <7262f25e0802070801w110b7807ped30e6b60763267e@mail.gmail.com>
Sender: Craig.Russell@Sun.COM
To: dev@openjpa.apache.org
Message-id: <82E136BE-8878-4C21-A803-F03B64F28C3E@SUN.com>
MIME-version: 1.0
Content-type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha1; boundary=Apple-Mail-25-757556745
References: <47A9E34E.6090109@apache.org>
 <B9C3707E-D49B-44B4-8FCB-0AD5C4D5F9AF@SUN.com>
 <7D253E1A-F21D-4A90-B43E-B5850B0BE910@yahoo.com>
 <47AB111A.3010007@apache.org>
 <7262f25e0802070801w110b7807ped30e6b60763267e@mail.gmail.com>

--Apple-Mail-25-757556745
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit

We can probably not lose history when converting if we examine all the  
as-is files and make the change on the appropriate machine.

If they have DOS line endings, set the eol-style property to native on  
a DOS machine. No changes.

If they have UNIX line endings, set the eol-style property to native  
on a UNIX machine. No changes.

Craig

On Feb 7, 2008, at 8:01 AM, Patrick Linskey wrote:

>> On the downside, the file that was in DOS line endings was  
>> converted on
>> the server and recorded in the change notice as the entire file  
>> changing.
>
> I really don't like the idea of losing all this easy history. Is this
> line-ending stuff really a problem? Don't most modern text editors
> support multiple line endings?
>
> It seems a waste to lose all that data just to make things easier for
> Notepad users....
>
> -Patrick
>
> On Feb 7, 2008 6:09 AM, David Ezzio <dezzio@apache.org> wrote:
>> Hi,
>>
>> Based on an experiment, it looks like the regimentation of existing
>> files to native will be easy to perform.
>>
>> In r619411, I changed two files from as-is to native.  One was  
>> present
>> on my client with Unix line endings and one was present with DOS line
>> endings.  I changed the eol property for both files to native and
>> committed.  When updated from the server, they both came down with  
>> DOS
>> line endings, the appropriate native translation for my Windows  
>> machine.
>>
>> On the downside, the file that was in DOS line endings was  
>> converted on
>> the server and recorded in the change notice as the entire file  
>> changing.
>>
>> I propose that I find an hour or two next week and regiment all files
>> with a non-native setting to the native setting (about 60% of the  
>> code
>> base).
>>
>> David
>>
>>
>> David Jencks wrote:
>>> I think infra strongly suggest everyone uses these svn client  
>>> settings
>>> to avoid most of this kind of problem:
>>>
>>> http://www.apache.org/dev/svn-eol-style.txt
>>>
>>> I think there are scripts to help normalize stuff that has strayed  
>>> from
>>> these recommendations but I'm not sure where they are.
>>>
>>> thanks
>>> david jencks
>>>
>>> On Feb 6, 2008, at 9:09 AM, Craig L Russell wrote:
>>>
>>>> Hi David,
>>>>
>>>> Thanks for volunteering to do this.
>>>>
>>>> I recall we discussed whether to use LF or native. But I don't  
>>>> recall
>>>> the outcome.
>>>>
>>>> The reason to use LF is for Windows users who use unix tools. The
>>>> reason to use native is for Windows users who use native tools
>>>> (Notepad). I personally don't care, except that my svn preferences
>>>> file is set up to use LF for new files (for another project).
>>>>
>>>> Craig
>>>>
>>>> On Feb 6, 2008, at 8:41 AM, David Ezzio wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> As I understand it, files within the SVN repository are either  
>>>>> text
>>>>> or binary, and if text, they have as a property one of the five  
>>>>> SVN
>>>>> settings: CR (Mac), LF (Unix), CRLF (DOS), native (convert to/from
>>>>> client platform) or as-is (no conversion, no regimentation).
>>>>>
>>>>> Currently, the OpenJPA repository has text files for three of  
>>>>> these
>>>>> settings.  Most are as-is, a few are LF, and the remainder are  
>>>>> native.
>>>>>
>>>>> As I understand it, native is the preferred attribute for text  
>>>>> files
>>>>> as SVN will take care to convert to and from the client's platform
>>>>> preference upon update and commit.
>>>>>
>>>>> I believe it would be a relatively simple matter for me to convert
>>>>> all of the files to one agreed upon format, anytime that we'd  
>>>>> care to
>>>>> do so.
>>>>>
>>>>> Thoughts?
>>>>>
>>>>> David
>>>>
>>>> Craig Russell
>>>> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
>>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>>> P.S. A good JDO? O, Gasp!
>>>>
>>>
>>>
>>
>
>
>
> -- 
> Patrick Linskey
> 202 669 5907

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


--Apple-Mail-25-757556745
Content-Disposition: attachment;
	filename=smime.p7s
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw
ggJyoAMCAQICECvOQSuIjHMvOZRC95BRg/wwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx
JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIxMDE1MjM1MVoXDTA4MTIwOTE1MjM1
MVowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny
YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC
ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAKzqGlLUastboCRqc0iBoTz2ODcqpMpEyPUo
nYtluchkSIoWzOW63AuoTczRt9sKfhwoK5mope+62B6Li06WJabm2UHqKAaNSuMHLsmyqvOdwbSt
enY7/HxOSCMqVoyVBTRJc2M8feCSVgi7ptGq9cM+Maa64R1/p9zqaQNucceU/1uper90bWplsjAT
rHgicgr9XJIQb6uYjhjlgxxnY/aispnCvLxMX+CiA2FWeeJTI7AiFlLwibTXYF4v12ToByvXtTiJ
knuND8qpwhK3Wp0tL4ae8mZ0nlKjCuNnqh99ZyEyTFHZBfVx8WSWRXkY4qxCG/IDQUo7WUaefOQT
1mECAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC
MAAwDQYJKoZIhvcNAQEFBQADgYEAEqfFNFoch0QPVKWJ4maAZl3MJD10yMeWt5xb+WNSkhYKHD8I
42E8tpdE3kmc5wp2cZrz9JqJF/KCQ/gI4pmDk1qpTs5pvXzFNiD5Lu5eLza4iyxSlTHUXcCnyNC6
4m0qC8p4m/51NEql5hyacj/+vdlEe5dygpyNGUCiyA/SdAswggM/MIICqKADAgECAgENMA0GCSqG
SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH
EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp
Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h
aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw
NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl
IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls
IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE
cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef
kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB
AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js
LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD
VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB
AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+
hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC
3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0ECECvOQSuIjHMvOZRC95BRg/wwCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN
AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDgwMjA3MTY1MDU2WjAjBgkqhkiG9w0B
CQQxFgQUKUcW7I0ZxCQq74oYWGwiefHctB0wgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC
WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0
ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhArzkEriIxzLzmUQveQUYP8MIGHBgsqhkiG
9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ
dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAr
zkEriIxzLzmUQveQUYP8MA0GCSqGSIb3DQEBAQUABIIBAJVVvtRiFmI5ii4Sa0wxSzfTbyUjKxHw
5ZdhjI07pUdocjt3q5srQ8AtdnMLN/ABw5leTyqvejD5JHgt2XQnVJmQKN8o+2YMLf94sXygV8Jd
wKrvTPQeQSEYrYbCA4vz6mwZyCIWcoJ6rDBGW03TBWZk+TQ52JoxnmgTuyj8qIj1NRQ8qGGkfB0T
LrR2NxUsjujEcr/OclxMxXFCIHi71rq1FrxISPbwuDrSW2h2FZNZalUx4ZTahcgAz/+NRS0d0DGX
hOPOeoqQsHZf4D7H2cOu/qIe+oXnnaVzpivqULunXnf7QwnFkVFhY5OCASyX6ufAPrV0vtaZQxGV
PCv2MhUAAAAAAAA=

--Apple-Mail-25-757556745--