Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Subject: Re: BUG: MySQL DDL Generation
From: Tim Holloway <timh@mousetech.com>
To: dev@openjpa.apache.org
In-Reply-To: <72c1350f0711271616m193b90bat54f9e706c3bdb344@mail.gmail.com>
References: <1194650044.14040.73.camel@maria2>
	 <1196206764.21916.71.camel@a64.camera.mousetech.com>
	 <72c1350f0711271616m193b90bat54f9e706c3bdb344@mail.gmail.com>
Content-Type: text/plain
Date: Wed, 28 Nov 2007 19:38:44 -0500
Message-Id: <1196296724.22005.6.camel@a64.camera.mousetech.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

Thanks. You might also want to open one on a problem I reported back on
Nov 6 where a malformed JDBC URL could throw an exception. This one only
happens to us incompetent folks.

Also, did I whine about the apparent mandatory requirement to supply a
schema to the Reverse Engineering tool (which the documentation doesn't
show)? I got bitten by it about a year ago, then again about 2 weeks
ago. That time I fixed it by googling the problem and finding my own
question in a mail archive.

   Tim

On Tue, 2007-11-27 at 18:16 -0600, Michael Dick wrote:
> I went ahead and opened the JIRA for you (OPENJPA-455). I'll take a closer
> look tomorrow, sorry for missing it earlier.
> 
> -Mike
> 
> On Nov 27, 2007 5:39 PM, Tim Holloway <timh@mousetech.com> wrote:
> 
> > I'm repeating this, since it never received action:
> >
> > On Fri, 2007-11-09 at 18:14 -0500, Tim Holloway wrote:
> > > I turned the schema tool loose on a MySQL production database this
> > > afternoon and it failed. The essence of the problem appears that DDL was
> > > being generated with a type declaration of this form:
> > >
> > > int unsigned(10)
> > >
> > > In MySQL, the proper form is:
> > >
> > > int(10) unsigned
> > >
> > > viz:
> > >
> > > ALTER TABLE fubar MODIFY col1 int(10) unsigned;
> > >
> > > Checking other options indicates that similar constructs such as CREATE
> > > TABLE are likewise defective.
> > >
> > > I looked at the svn trunk head source code in
> > > org.apache.openjpa.jdbc.sql.MySQLDictionary.java and the parent class
> > > DBDictionary.java. The offending method appears to be:
> > >
> > > 1508:     public String getTypeName(Column col)
> > >
> > > This method has no override in MySQLDictionary, but apparently needs
> > > one. I think it's a minor mod, but I'm not currently set up to build and
> > > test in the environment where the offending database exists.
> > >
> > > This is a SEVERE error. It causes generation of defective SQL for
> > > SQL-generating options and causes live updates to schemas to fail.
> > >
> > > I don't have a Jira login at present, so if someone could log this, it
> > > would be appreciated.
> > >
> > >    Thanks,
> > >
> > >     Tim Holloway
> > >
> >
> >