Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: domain of plinskey@gmail.com designates
 64.233.170.190 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Z06dpUbjMiREUM7T+qg1cj9m9XSx2HgggMtkM4zWUj4I6RTPbESgAehkOPwDeS8APV370m/sARYRBd4r2WgnlRWqCtVKrqeYXlphd5PQEegeCgxwUmMflXRptvTGNk4NgkLmRYPy5nQk088b3sF4nNoXdFO783DQHygdcPjQ7r0=
Message-ID: <7262f25e0710171505x3eadb65eq28952b9f6551bef0@mail.gmail.com>
Date: Wed, 17 Oct 2007 15:05:06 -0700
From: "Patrick Linskey" <plinskey@gmail.com>
To: dev@openjpa.apache.org
Subject: Re: error message for native sql parameters
In-Reply-To: <89c0c52c0710170929vadb96bpcb9104e3c1889abc@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <89c0c52c0710170929vadb96bpcb9104e3c1889abc@mail.gmail.com>

Sounds like a good solution to me.

-Patrick

On 10/17/07, Kevin Sutter <kwsutter@gmail.com> wrote:
> Hi,
> One of our customers stumbled over this error message when parsing a
> @NamedNativeQuery:
>
> bad-param-name: The parameter name or position "{0}" passed to \
>     execute() is not valid.  All map keys must be a declared parameter \
>     name or a number matching the parameter position.
>
> The @NamedNativeQuery was as follows:
>
> @NamedNativeQuery(name="getStationKeyForUpdate",
>         query="SELECT * from KEYGEN where KEYNAME = :keyname FOR UPDATE")
>
> Native Queries only allow positional parameters.  This customer thought that
> the error message should be clearer since it mentions that named parameters
> may also be allowed.
>
> I looked at the code in question and we use the same processing for named
> and positional parameter for both jpql and native queries.  So, it would be
> overkill (in my mind) to separate out the processing just to clarify the
> syntax requirements of the various queries.
>
> So, would there be any problem with just adding the following to the error
> message:
>
> bad-param-name: The parameter name or position "{0}" passed to \
>     execute() is not valid.  All map keys must be a declared parameter \
>     name or a number matching the parameter position.  Native queries \
>     only allow positional parameters.
>
> It clarifies the problem without introducing a lot of extra processing.
>
> Kevin
>


-- 
Patrick Linskey
202 669 5907