openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Linskey" <plins...@gmail.com>
Subject Re: [jira] Reopened: (OPENJPA-370) LoadFetchGroup annotation was not recognized during the fetch1
Date Mon, 29 Oct 2007 16:46:39 GMT
> LoadFetchGroup at all. If we really want to keep the LoadFetchGroup, then we
> need to re-architect it to use the real FetchGroup object and saves it in
> the class, field and column objects.

Personally, I would expect that this would be a blocking issue for a
1.0.1 release, considering its performance impact.

Regardless of release vehicle, let's come up with a plan for resolving
this issue. IMO, this is a big problem.

-Patrick

On 10/23/07, Teresa Kan <tckan1@gmail.com> wrote:
> Hi Patrick,
> As I mentioned previously, there were two patches and patch1 was quick and
> dirty;  whereas patch2 was more incline with the current architecture but
> has performance impact. The question is that why did we introduce the
> LoadFetchGroup concept at the beginning? With the fetch group itself, users
> can create as many as fetchgroups they want, we don't really need the
> LoadFetchGroup at all. If we really want to keep the LoadFetchGroup, then we
> need to re-architect it to use the real FetchGroup object and saves it in
> the class, field and column objects.
>
> Teresa
>
>
>
> On 10/23/07, Patrick Linskey (JIRA) <jira@apache.org> wrote:
> >
> >
> >     [
> > https://issues.apache.org/jira/browse/OPENJPA-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
> >
> > Patrick Linskey reopened OPENJPA-370:
> > -------------------------------------
> >
> >
> > It looks like this patch might have a performance impact due to the
> > additional time required to compute field inclusion. We should consider
> > other implementation routes or potentially rolling this back on the 1.0.xbranch
prior to
> > 1.0.1, depending on what we decide our release criteria should be.
> >
> > > LoadFetchGroup annotation was not recognized during the fetch1
> > > --------------------------------------------------------------
> > >
> > >                 Key: OPENJPA-370
> > >                 URL: https://issues.apache.org/jira/browse/OPENJPA-370
> > >             Project: OpenJPA
> > >          Issue Type: Bug
> > >          Components: kernel
> > >    Affects Versions: 1.0.1, 1.1.0
> > >            Reporter: Teresa Kan
> > >            Assignee: Teresa Kan
> > >             Fix For: 1.0.1, 1.1.0
> > >
> > >         Attachments: OPENJPA_370_2.patch, TestFetchGroup.zip
> > >
> > >
> > > Employee class has a LoadFetchGroup annotation defined on the Rating
> > field, when getRating was called, the address should be returned also.
> > However, openjpa did not handle the LoadFetchGroup correctly, therefore,
> > address was not eargly fetched.
> > > public class FGEmployee{
> > >     @Id
> > >     private int id;
> > >
> > >     @OneToOne(fetch=FetchType.LAZY)
> > >     private FGAddress address;
> > >
> > >     @Basic(fetch=FetchType.LAZY)
> > >     @LoadFetchGroup("AddressFetchGroup")
> > >     private String rating;
> > >
> > >     @ManyToOne(fetch=FetchType.LAZY)
> > >     private FGManager manager;
> > > ..
> > > }
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>


-- 
Patrick Linskey
202 669 5907

Mime
View raw message