openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <>
Subject [jira] Commented: (OPENJPA-396) Cloning Calendar proxies doesn't detach from StateManager
Date Mon, 08 Oct 2007 17:25:50 GMT


Craig Russell commented on OPENJPA-396:

Hi Kevin,

One question. In the generated clone method, after calling super.clone(), why do you not simply
invoke stateManager = null; pcState = 0; instead of calling the setOwner(null, 0) method?

Seems like there is additional code in setOwner that you want to avoid because there is not
yet any relationship between the owner and the sco. The effect of calling this method from
the clone might be to disassociate the original sco.

> Cloning Calendar proxies doesn't detach from StateManager
> ---------------------------------------------------------
>                 Key: OPENJPA-396
>                 URL:
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.0.0, 1.0.1, 1.1.0
>            Reporter: Kevin Sutter
>            Assignee: Kevin Sutter
>             Fix For: 1.0.1, 1.1.0
>         Attachments: OPENJPA-396.patch
> This problem was first discussed on our dev mailing list:
> Per the discussion on that thread, I am proposing to modify the generated proxy code
to override the clone() method.  This clone() method will do the necessary copying of data
from the original object, but then also null out the sm (StateManager) and zero out the field
attributes.  This action detaches the cloned object from the StateManager (and associated
> Instead of limiting this action to the Calendar proxy, I am adding the clone() method
implementation to all of our proxy objects that we generate.  Granted, some of the object
types do not directly support the clone() method, but that will be detected when or if anybody
attempts to use the clone() method on these types (compiler generated error message).
> I'll be posting a patch shortly and I plan to commit the changes later today (unless
there is opposition).
> Thanks,
> Kevin

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message