openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Linskey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-370) LoadFetchGroup annotation was not recognized during the fetch1
Date Tue, 30 Oct 2007 02:52:50 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538649
] 

Patrick Linskey commented on OPENJPA-370:
-----------------------------------------

> But, my take is that we should focus our efforts on this improvement in the 
> 1.1.0 trunk instead of pulling the functional implementation from the 1.0.x branch.

I'm not as concerned with the 1.0.x behavior as with the 1.1.0 behavior, since I'm not in
the process of releasing a product based on the 1.0.x branch.

I do believe that the performance degradation is significant and important.

> Unless someone is volunteering to redo the fix for 1.0.x to be both functional
> and better performing, and a timely manner... :-) 

I'm a bit concerned about the sentiment behind this statement. I think that performance regressions
are big deals, and based on what I've seen from the performance impact of this patch, I basically
think that the patch does not work. Sure, it resolves the issue, but it causes regressions
in other areas of the product. As I mentioned, I'm ok letting things slide for 1.0.1, given
that I understand that the goal of 1.0.1 is to get a product out. But I do not like it, and
personally would prefer to see the behavior either fixed in a performant manner or backed
out, especially in what we are claiming is a maintenance branch. And I definitely think that
resolving this has to be a top priority.

> LoadFetchGroup annotation was not recognized during the fetch1
> --------------------------------------------------------------
>
>                 Key: OPENJPA-370
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-370
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.0.1, 1.1.0
>            Reporter: Teresa Kan
>            Assignee: Teresa Kan
>             Fix For: 1.0.1, 1.1.0
>
>         Attachments: OPENJPA_370_2.patch, TestFetchGroup.zip
>
>
> Employee class has a LoadFetchGroup annotation defined on the Rating field, when getRating
was called, the address should be returned also. However, openjpa did not handle the LoadFetchGroup
correctly, therefore, address was not eargly fetched.
> public class FGEmployee{
>     @Id
>     private int id;
>  
>     @OneToOne(fetch=FetchType.LAZY) 
>     private FGAddress address;
>  
>     @Basic(fetch=FetchType.LAZY)
>     @LoadFetchGroup("AddressFetchGroup")
>     private String rating;
>  
>     @ManyToOne(fetch=FetchType.LAZY)
>     private FGManager manager;
> ..
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message