Return-Path: 
 <dev-return-5764-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org>
Delivered-To: apmail-openjpa-dev-archive@www.apache.org
Received: (qmail 62119 invoked from network); 21 Aug 2007 15:06:20 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 21 Aug 2007 15:06:20 -0000
Received: (qmail 49689 invoked by uid 500); 21 Aug 2007 15:06:17 -0000
Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org
Received: (qmail 49656 invoked by uid 500); 21 Aug 2007 15:06:17 -0000
Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@openjpa.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@openjpa.apache.org>
List-Post: <mailto:dev@openjpa.apache.org>
List-Id: <dev.openjpa.apache.org>
Reply-To: dev@openjpa.apache.org
Delivered-To: mailing list dev@openjpa.apache.org
Received: (qmail 49647 invoked by uid 99); 21 Aug 2007 15:06:17 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Aug 2007 08:06:17 -0700
X-ASF-Spam-Status: No, hits=2.0 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of kwsutter@gmail.com designates
 209.85.146.177 as permitted sender)
Received: from [209.85.146.177] (HELO wa-out-1112.google.com) (209.85.146.177)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Aug 2007 15:06:16 +0000
Received: by wa-out-1112.google.com with SMTP id m33so1168011wag
        for <dev@openjpa.apache.org>; Tue, 21 Aug 2007 08:05:55 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed;
        d=gmail.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=Rx3ZnMLzeYLO0mSdEWR7YLqyGXgMZFlYE9bb8fj5vabbekg0ya3oxXWRofCZfPx6HjqI0NlXmh37+gonLeb2vT/2GRoN+fYoH5e8cG88ytj7yn3sIolv8YCxE6pKy3WFS6f0hBWi9DNxgr2/8alV9EHy0T+0Kg9Fe499eRNnGpA=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=QmywZz02V9YiZGXFBTgIzALYyrQ/hDICl9edYAmWz3bWWuQ1tiRsgVg6wF3Tazm2OeBkzlDGGn1odo29XGwrpRxKB/RwDiDgOlgJtS8wzmcdk8fTOHsZQGUrEiYjk2GsW4r3F+RtirEa8InnYxTzGXXhRRKhGNSotqx45kvRCvM=
Received: by 10.114.174.2 with SMTP id w2mr4643267wae.1187708753292;
        Tue, 21 Aug 2007 08:05:53 -0700 (PDT)
Received: by 10.114.75.15 with HTTP; Tue, 21 Aug 2007 08:05:53 -0700 (PDT)
Message-ID: <89c0c52c0708210805k29fa1c92p2a7467021f437f2f@mail.gmail.com>
Date: Tue, 21 Aug 2007 10:05:53 -0500
From: "Kevin Sutter" <kwsutter@gmail.com>
To: dev@openjpa.apache.org
Subject: Re: svn commit: r567962 -
 /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DB2Dictionary.java
In-Reply-To: <A8057AB3-E96B-4CD7-B1A7-973F64F5C2B4@apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_30837_10404291.1187708753242"
References: <20070821052616.2F0741A981A@eris.apache.org>
	 <89c0c52c0708210528p2fc7389fu5cd0eddcc456fb0f@mail.gmail.com>
	 <7262f25e0708210741o31c8d8b8xb0ecf65d9bac96d6@mail.gmail.com>
	 <A8057AB3-E96B-4CD7-B1A7-973F64F5C2B4@apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

------=_Part_30837_10404291.1187708753242
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Yeah, this is what Mike and I came up with as well...  I'm not aware of a
maven feature to allow for multiple java runtimes...

On 8/21/07, Marc Prud'hommeaux <mprudhom@apache.org> wrote:
>
>
> Also, you can have the validation automatically happen if your ~/.m2/
> settings.xml looks like:
>
> <settings>
>      <profiles>
>          <profile>
>              <id>java14-validate</id>
>              <activation><activeByDefault>true</activeByDefault></
> activation>
>              <properties>
>                  <java14.jar>/System/Library/Frameworks/
> JavaVM.framework/Versions/1.4.2/Classes/classes.jar</java14.jar>
>              </properties>
>          </profile>
>      </profiles>
> </settings>
>
> The exact location of "java14.jar" is platform and installation
> specific, which is why we can't automatically set it (unless anyone
> has any clever suggestions for figuring out the path of different
> JVM's installation in a robust manner).
>
>
>
> On Aug 21, 2007, at 10:41 AM, Patrick Linskey wrote:
>
> > On 8/21/07, Kevin Sutter <kwsutter@gmail.com> wrote:
> >> Nice catches, Patrick.  These 1.5-specific items keep slipping
> >> through.
> >> I've been talking with Mike and Marc about this -- maybe there's
> >> something
> >> more automated that can be done to help prevent these type of
> >> changes from
> >> slipping through.
> >
> > So Marc and I both catch these things because we're running automated
> > build systems that run with the elaborate arguments required to link
> > against the 1.4 jars. One possibility would be for you guys to compile
> > with those same args, but that's a bit of a pain. Another would b e
> > for me to finally get around to making my CI system available to
> > others who want access to it. I'll look into that in the next day or
> > so.
> >
> >> The other change you caught with the unbalanced parens kind of
> >> scares me.
> >> We ran both the regression bucket and JPA TCK against DB2 without
> >> this
> >> getting caught.  Maybe this particular path isn't executed by
> >> those tests.
> >> I am checking with Teresa to see if we need some new testcases for
> >> this.
> >
> > As Teresa mentioned, the code itself was fine; the balancing was just
> > being done across a method boundary.
> >
> > -Patrick
> >
> > --
> > Patrick Linskey
> > 202 669 5907
>
>

------=_Part_30837_10404291.1187708753242--