Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Received-SPF: pass (athena.apache.org: domain of kwsutter@gmail.com designates
 209.85.198.191 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=Qy/akDM14uEgCgYvY1+crPTElE6CxBdduhG+8b1L5S54VJv7uW9jVFYjgLvgIzgwLhrQ0AS3/KZwsl+Kj/13qVVAIc9KQR/4GOP12oApSUP0LL4YugiTdNHWHSvkXwJQK9Cx5dlTbmToZYrbLXu5wy7nj165sOjngAvXyPw075k=
Message-ID: <89c0c52c0708171326k4ddf8de9j8547e7588381985@mail.gmail.com>
Date: Fri, 17 Aug 2007 15:26:36 -0500
From: "Kevin Sutter" <kwsutter@gmail.com>
To: dev@openjpa.apache.org
Subject: Re: svn commit: r567127 -
 /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
In-Reply-To: <20070817201625.D92441A981D@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_253442_15677630.1187382396089"
References: <20070817201625.D92441A981D@eris.apache.org>

------=_Part_253442_15677630.1187382396089
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Marc,
How do you find these 1.5-ism's?  You caught one of my previous 1.5-ism's as
well.  When I do the maven build, nothing is flagged.  Or, are these only
warnings and I need to be looking closer?  Just wondering if you have some
other build trick that makes detecting these before we commit these type of
changes.

Thanks,
Kevin

On 8/17/07, mprudhom@apache.org <mprudhom@apache.org> wrote:
>
> Author: mprudhom
> Date: Fri Aug 17 13:16:25 2007
> New Revision: 567127
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=567127
> Log:
> Fixed JDK 1.5-ism of Character.valueOf(char) by changing it to new
> Characher(char).
>
> Modified:
>
>     openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
>
> Modified:
> openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
> URL:
> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java?view=diff&rev=567127&r1=567126&r2=567127
>
> ==============================================================================
> ---
> openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
> (original)
> +++
> openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
> Fri Aug 17 13:16:25 2007
> @@ -77,7 +77,7 @@
>              case JavaTypes.INT:
>                  return Integer.valueOf(_value);
>              case JavaTypes.CHAR:
> -               return Character.valueOf
> (_value.charAt(_value.indexOf('\'')+1));
> +               return new
> Character(_value.charAt(_value.indexOf('\'')+1));
>              case JavaTypes.STRING:
>              default:
>                  return _value;
>
>
>

------=_Part_253442_15677630.1187382396089--