Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 26967 invoked from network); 20 Aug 2007 23:49:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Aug 2007 23:49:31 -0000 Received: (qmail 90800 invoked by uid 500); 20 Aug 2007 23:49:28 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 90652 invoked by uid 500); 20 Aug 2007 23:49:28 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 90643 invoked by uid 99); 20 Aug 2007 23:49:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2007 16:49:28 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of plinskey@gmail.com designates 64.233.166.182 as permitted sender) Received: from [64.233.166.182] (HELO py-out-1112.google.com) (64.233.166.182) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2007 23:49:59 +0000 Received: by py-out-1112.google.com with SMTP id f31so2228150pyh for ; Mon, 20 Aug 2007 16:49:05 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pB56N2xDWvB/efo09AGipS+EfQp5QcoAkAwo55Uy/2FU3EVgamQMZni0FOdirPZCVMpqlE0e9w7f/E+hhmCelsM4XiE26ftRNhzAurN4OjKpzfFNT1ibi60oAOVHfmZMPlwJFDuLaEzILzJ5ly7dN2WFRAR4pAGBtnq65CzkBJ0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ZbaQQeiosHfybW2hBigxQ4r/tWS41GD7XRCIKOL116wpA87UYqbt0C3Kr9GhZvgyU/qp8PRi/IwWkKoBn+XslD3/JmHEjrmiHr0kdx4y8vT4PJdG3ue3nZM3mWewn2QqnDdsNwsniqggYXKLw/e9ktcZ2/EW7tFLlI4rGKHFaeQ= Received: by 10.35.71.1 with SMTP id y1mr8025523pyk.1187653744330; Mon, 20 Aug 2007 16:49:04 -0700 (PDT) Received: by 10.35.8.4 with HTTP; Mon, 20 Aug 2007 16:49:03 -0700 (PDT) Message-ID: <7262f25e0708201649m1dbdf912t3fd9769334bb7b47@mail.gmail.com> Date: Mon, 20 Aug 2007 16:49:03 -0700 From: "Patrick Linskey" To: dev@openjpa.apache.org Subject: Re: API changes In-Reply-To: <89c0c52c0708200625w55ca6b85hcc47e08877c9932@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7262f25e0708192345v78e9960fkfe2fd6b52afd4f9e@mail.gmail.com> <89c0c52c0708200625w55ca6b85hcc47e08877c9932@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org So one issue with this is that some of these settings are configurable in persistence.xml, and we use 'FooMode' there. For example, ConnectionRetainMode. This is easy enough to fix, and can be done in the future by deprecating the current setting, so it's probably not a big consideration. -Patrick On 8/20/07, Kevin Sutter wrote: > Patrick, > If I was forced to pick one, I would go with FooType, but I am flexible > either way. > > Kevin > > On 8/20/07, Patrick Linskey wrote: > > > > Hi, > > > > I think that I'm mostly done with the API changes -- see OPENJPA-317. > > > > One outstanding issue is a naming problem. Internally, we use a > > 'FooMode' naming structure for lots of our symbolic constants, but the > > JPA spec uses a 'FooType' naming structure for its enums. Which should > > we obey? The most recent patch mostly goes the 'FooType' route. > > > > -Patrick > > > > -- > > Patrick Linskey > > 202 669 5907 > > > -- Patrick Linskey 202 669 5907