Return-Path: Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: (qmail 83430 invoked from network); 7 Aug 2007 18:44:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Aug 2007 18:44:22 -0000 Received: (qmail 15665 invoked by uid 500); 7 Aug 2007 18:44:21 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 15637 invoked by uid 500); 7 Aug 2007 18:44:21 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 15627 invoked by uid 99); 7 Aug 2007 18:44:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2007 11:44:21 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2007 18:44:15 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2FE4D714191 for ; Tue, 7 Aug 2007 11:43:59 -0700 (PDT) Message-ID: <11305772.1186512239176.JavaMail.jira@brutus> Date: Tue, 7 Aug 2007 11:43:59 -0700 (PDT) From: "Patrick Linskey (JIRA)" To: dev@openjpa.apache.org Subject: [jira] Updated: (OPENJPA-137) Perform parameter validation for annotated callback methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Linskey updated OPENJPA-137: ------------------------------------ Fix Version/s: (was: 1.0.0) > Perform parameter validation for annotated callback methods > ----------------------------------------------------------- > > Key: OPENJPA-137 > URL: https://issues.apache.org/jira/browse/OPENJPA-137 > Project: OpenJPA > Issue Type: Sub-task > Components: jpa > Reporter: Kevin Sutter > Priority: Minor > > This is a follow-on Issue to OPENJPA-133. Issue 133 was concerned with properly processing the xml configuration of callback methods. As I was experimenting with that scenario, I discovered that our processing for annotated callback methods and xml callback methods is not consistent. While we do parameter validation for the xml-configured callbacks, we do not do any validation of the annotated callback methods. We just assume that the signature is valid. An incorrectly configured annotated callback method is not detected until runtime and then the user will get an IllegalArgumentException. It's good that we eventually catch and log this condition, but if we could do the validation earlier like we do for xml-configured callbacks, the user will know about the problem much earlier in the process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.