openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-244) Java 2 Security enablement
Date Thu, 09 Aug 2007 00:23:04 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518583
] 

Craig Russell commented on OPENJPA-244:
---------------------------------------

Looks good. Just a couple of comments:

1. Lots of cases of white space differences. Here's an example:
Index: openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java
===================================================================
--- openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java	(revision 562121)
+++ openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java	(working copy)
@@ -14,7 +14,7 @@
  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  * KIND, either express or implied.  See the License for the
  * specific language governing permissions and limitations
- * under the License.    
+ * under the License.

I have no objection to cleaning up white space (removing trailing spaces, converting tabs
to spaces, etc.) but it should be a separate checkin with an innocuous "Fixed white space"
comment.

2. In file Index: openjpa-kernel/src/main/java/org/apache/openjpa/util/Serialization.java
should we define a new action for this case:
@@ -104,7 +105,12 @@
             throws IOException {
             super(delegate);
             _ctx = ctx;
-            enableReplaceObject(true);
+            AccessController.doPrivileged(new PrivilegedAction() {
+                public Object run() {
+                    enableReplaceObject(true);
+                    return null;
+                }
+            });
         }
like J2DoPrivHelper.replaceObject()?

3. And the same for enableResolveObject?



> Java 2 Security enablement
> --------------------------
>
>                 Key: OPENJPA-244
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-244
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 0.9.8
>            Reporter: Kevin Sutter
>            Assignee: Albert Lee
>         Attachments: OPENJPA-244.patch, OPENJPA.244-2.patch
>
>
> Via some testing with the WebSphere Application Server, it's been discovered that we're
missing some doPriv blocks through out the OpenJPA code base.  This JIRA report will be used
to resolve these issues.  More specific examples will be posted later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message