openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sutter" <kwsut...@gmail.com>
Subject Re: svn commit: r567127 - /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
Date Fri, 17 Aug 2007 20:26:36 GMT
Marc,
How do you find these 1.5-ism's?  You caught one of my previous 1.5-ism's as
well.  When I do the maven build, nothing is flagged.  Or, are these only
warnings and I need to be looking closer?  Just wondering if you have some
other build trick that makes detecting these before we commit these type of
changes.

Thanks,
Kevin

On 8/17/07, mprudhom@apache.org <mprudhom@apache.org> wrote:
>
> Author: mprudhom
> Date: Fri Aug 17 13:16:25 2007
> New Revision: 567127
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=567127
> Log:
> Fixed JDK 1.5-ism of Character.valueOf(char) by changing it to new
> Characher(char).
>
> Modified:
>
>     openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
>
> Modified:
> openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
> URL:
> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java?view=diff&rev=567127&r1=567126&r2=567127
>
> ==============================================================================
> ---
> openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
> (original)
> +++
> openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/DiscriminatorMappingInfo.java
> Fri Aug 17 13:16:25 2007
> @@ -77,7 +77,7 @@
>              case JavaTypes.INT:
>                  return Integer.valueOf(_value);
>              case JavaTypes.CHAR:
> -               return Character.valueOf
> (_value.charAt(_value.indexOf('\'')+1));
> +               return new
> Character(_value.charAt(_value.indexOf('\'')+1));
>              case JavaTypes.STRING:
>              default:
>                  return _value;
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message