openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Linskey" <plins...@gmail.com>
Subject Re: Names of patches for jira issues
Date Sat, 11 Aug 2007 00:59:13 GMT
I tend to use all-caps, just because that's auto-generated by
IntelliJ's change set capabilities.

-Patrick

On 8/10/07, Pinaki Poddar <ppoddar@bea.com> wrote:
> +1
>
> A small addition to Craig's proposed convention:
> ppenjpa-xxx.z.patch or openjpa-xxx.z.txt
> where xxx is the JIRA issue number and z is the patch number as often
> there are multiple versions of the patch on the same issue.
>
>
> Pinaki Poddar
> 972.834.2865
>
> -----Original Message-----
> From: Craig.Russell@Sun.COM [mailto:Craig.Russell@Sun.COM]
> Sent: Friday, August 10, 2007 7:07 PM
> To: dev@openjpa.apache.org
> Subject: Names of patches for jira issues
>
> I'd like to propose an informal convention for jira patch attachments.
>
> 1. Use the name of the jira in the patch file name, and use either a
> .txt or .patch suffix.
>
> 2. Do the svn diff >openjpa-249.patch from trunk.
>
> These small things make it easier when downloading the patch to know
> where it applies and you don't have to rename the patch to remember
> which issue it applies to.
>
> Obviously, no one will complain about details like this when getting
> patches "free as in work" but it might make it a bit easier to verify
> them.
>
> What do you all think?
>
> Craig
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp!
>
>
> Notice:  This email message, together with any attachments, may contain information 
of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated entities,  that may be confidential,
 proprietary,  copyrighted  and/or legally privileged, and is intended solely for the use
of the individual or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this by email and then
delete it.
>


-- 
Patrick Linskey
202 669 5907

Mime
View raw message