openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Linskey (JIRA)" <>
Subject [jira] Commented: (OPENJPA-317) API formalization pre-1.0
Date Tue, 21 Aug 2007 04:55:30 GMT


Patrick Linskey commented on OPENJPA-317:

> 1. Maybe this was already discussed on another thread and
> I missed it, but the naming convention for the SPI interfaces
> is a bit different from what I am used to. Instead of appending
> SPI to the interface name, I'm more used to putting .spi. in the
> package name. Something like this: 

It was not discussed at all, and I basically ignored the issue altogether. I decided to just
focus on the API; now that we've got that nailed down, we can do whatever we want with the
rest. Since the SPI classes are not part of the published API set, we should feel free to
totally change everything to do with them as we see fit.

Similar logic applies to the casting issue that you raised. I think that we could definitely
do some cleanup there, but I didn't see a lot of need pre-1.0.

Note that I did make OpenJPAEntityManagerFactorySPI have a covariant return type for createEM(),
so if you've casted once, you're in good shape from there onwards. I tried to use covariant
types wherever possible in this way.

> API formalization pre-1.0
> -------------------------
>                 Key: OPENJPA-317
>                 URL:
>             Project: OpenJPA
>          Issue Type: New Feature
>          Components: jpa
>    Affects Versions: 0.9.0, 0.9.6, 0.9.7
>            Reporter: Patrick Linskey
>             Fix For: 1.0.0
>         Attachments: OPENJPA-317.patch, OPENJPA-317.patch
> This issue tracks the effort to formalize and optimize our API prior to the 1.0 release.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message