Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 81640 invoked from network); 6 May 2007 21:27:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 May 2007 21:27:50 -0000 Received: (qmail 82248 invoked by uid 500); 6 May 2007 21:27:56 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 82218 invoked by uid 500); 6 May 2007 21:27:56 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 82209 invoked by uid 99); 6 May 2007 21:27:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 May 2007 14:27:56 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of mprudhomapache@gmail.com designates 64.233.184.228 as permitted sender) Received: from [64.233.184.228] (HELO wr-out-0506.google.com) (64.233.184.228) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 May 2007 14:27:48 -0700 Received: by wr-out-0506.google.com with SMTP id i31so1473612wra for ; Sun, 06 May 2007 14:27:27 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=so1IcTecyg1jUQ06Noo+8UyhIyzt5T/hXUv8aCDtgdj8uaRmVOPtXB/F2HJJceaxeS0lP8ujBUI+MmKE8vt2U07tDD/rx/d+ZoofRjP96JZcndx6rDQ3zY9SlRp+k3jPzbi8wJkasP5EwzjSp3SsyPQ5YDuPemxI+6emId1Sfok= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=KEKCRnGs+jXWCXQ+Mq9VZ9P1YR1GUJ1vgHpfksvV5B3mbojAZJbs7L35foZdv55aZf8tvuUak+Cy/TVgl6nJ4DNh/fbP6u4A6Zgn3ak7xJhxZHUFyTGJ/LilfBjdZklbbFfnmPSwdNnxaIOW5UjTvc3L3ze6jmE5GSQBMwCNJaA= Received: by 10.114.126.1 with SMTP id y1mr1909451wac.1178486845618; Sun, 06 May 2007 14:27:25 -0700 (PDT) Received: from ?192.168.15.100? ( [67.189.29.203]) by mx.google.com with ESMTP id z15sm1315489pod.2007.05.06.14.27.23; Sun, 06 May 2007 14:27:24 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <72c1350f0705040655n6a01625cx983da1af9fe60ed1@mail.gmail.com> References: <1CCBD60F-B7DF-43D1-87F1-E89C0974B7C7@SUN.com> <72c1350f0705040655n6a01625cx983da1af9fe60ed1@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marc Prud'hommeaux Subject: [VOTE] Packaging with maven Date: Sun, 6 May 2007 14:27:19 -0700 To: open-jpa-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.3) Sender: Marc Prud'hommeaux X-Virus-Checked: Checked by ClamAV on apache.org Poking around the ActiveMQ pom.xml files, I notice that you can have a different artifactId than the module name (i.e., directory) you are in. I hadn't known you could do this. Currently, our artifacts name are: trunk/pom.xml: openjpa trunk/openjpa-all/pom.xml: openjpa-all trunk/openjpa-project/pom.xml: openjpa-project We could change these to: trunk/pom.xml: openjpa-parent trunk/openjpa-all/pom.xml: openjpa trunk/openjpa-project/pom.xml: apache-openjpa I've tested this out, and it results in the openjpa aggregate jar being named "openjpa-VERSION.jar", the dependency being simply named "openjpa", and the assembly is named "apache-openjpa-VERSION.zip". None of the directories needed to be renamed. I've attached the patch that does this to https://issues.apache.org/jira/browse/OPENJPA-194 Since this will mess up people who currently have maven dependencies on OpenJPA (i.e., people who depend on "openjpa-all" will now need to depend on "openjpa"), we should probably get this hammered out before leaving incubation. So I've gone ahead and turned the [DISCUSS] into a [VOTE] to see if we should go ahead and do this. A vote of +1 means we should do the renaming, -1 means we should not, and 0 means "don't care". The vote will remain open until Wednesday May 9th at 23:59 GMT. On May 4, 2007, at 6:55 AM, Michael Dick wrote: > Some comments below > > On 5/4/07, Craig L Russell wrote: >> >> I'd like reopen the discussion on how to package and name our >> artifacts. I think the current setup could be improved, to give a >> better experience for users who might not be using maven for >> dependency management. It's easy for us to change now before >> graduation because once we graduate, people will need to update their >> dependencies anyway so there are no backward compatibility issues. >> >> The name of the single jar that has all of the openjpa stuff in it >> except for the documentation and examples is currently called >> openjpa- >> all. This name is confusing because unless they RTFM, people don't >> really know that it's not all the code you need, just all the jpa >> code. So I'd like to call this artifact openjpa. > > > +1 > > But we already have a project with that name, and that project builds >> the distributions. So I'd rename the current openjpa to openjpa-dist. >> Its ultimate destination in the Apache mirror structure is under >> www.apache.org/dist/openjpa once we graduate, so having dist in the >> project name helps understanding that this project builds the >> artifacts that go into dist. Separate from the artifacts that are >> published via maven. > > > +1 > > Finally, the openjpa-all jar includes its subcomponents as >> dependencies. I think this is wrong, since you end up with a class >> path with openjpa-all.jar as well as openjpa-kernel.jar and all the >> others. > > > I would like to change this too. I did a little experimenting and > it looks > like the dependencies aren't needed in openjpa-all, but they are > needed for > openjpa-project (to populate the lib directory). Moving the > dependencies > into openjpa-project should be safe. > > We're also going to need to change the deploy logic to strip out the > -project suffix from the zip files. We've talked about it before > when I was > releasing 0.9.7 (and before that when Marc was working on 0.9.6), > but I > haven't had time to look into it. It should be fairly easy to make the > change. > > > Thoughts? >> >> Craig >> >> Craig Russell >> Architect, Sun Java Enterprise System http://java.sun.com/products/ >> jdo >> 408 276-5638 mailto:Craig.Russell@sun.com >> P.S. A good JDO? O, Gasp! >> >> >> > -Michael Dick