Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: open-jpa-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Date: Mon, 07 May 2007 09:45:41 -0700
From: Craig L Russell <Craig.Russell@Sun.COM>
Subject: Re: [VOTE] Packaging with maven
In-reply-to: <85BB636B-D676-452C-A7F0-4B30E6FF803D@apache.org>
Sender: Craig.Russell@Sun.COM
To: open-jpa-dev@incubator.apache.org
Message-id: <B0398193-C788-4D6B-8485-C546F30FF739@SUN.com>
MIME-version: 1.0
Content-type: multipart/signed; protocol="application/pkcs7-signature";
 boundary=Apple-Mail-199-533162792; micalg=sha1
References: <1CCBD60F-B7DF-43D1-87F1-E89C0974B7C7@SUN.com>
 <72c1350f0705040655n6a01625cx983da1af9fe60ed1@mail.gmail.com>
 <F806E14A-81B1-4C60-9165-CA0BACC30F16@apache.org>
 <72c1350f0705070903r57eb3fc0wba448dacc67bc55c@mail.gmail.com>
 <7262f25e0705070915k4f47ac1bn8710a557ddc40997@mail.gmail.com>
 <85BB636B-D676-452C-A7F0-4B30E6FF803D@apache.org>

--Apple-Mail-199-533162792
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed

I agree that it doesn't matter what we call the openjpa-parent  
directory. Trunk is ok.

But I do think we should rename the openjpa-all to openjpa to be  
consistent with the artifact name and location in the directory  
structure. The difference in my mind is that the openjpa-parent isn't  
an artifact that we ship.


On May 7, 2007, at 9:26 AM, Marc Prud'hommeaux wrote:

>
> Patrick raises a good point. Also, we might also be able to just  
> have the "openjpa" aggregate jar module be in a sub-directory named  
> "openjpa" without having to rename the parent module's enclosing  
> directory, since I don't think Maven much cares what the name of  
> the directory in which the parent module resides (I doubt it even  
> ever looks at it). I.e., it would be located at http:// 
> svn.apache.org/repos/asf/openjpa/trunk/openjpa/openjpa.

I'm confused now. The trunk has openjpa-kernel, openjpa-all, and all  
the other directories each of which is a maven project. I'd propose  
simply renaming trunk/openjpa-all to trunk/openjpa to match the  
artifactId of the aggregate jar.

And we still need to decide on the artifactId and directory name for  
openjpa-project.

Craig
>
> How does that sound?
>
>
>
> On May 7, 2007, at 9:15 AM, Patrick Linskey wrote:
>
>> I think it makes sense to rename dirs as appropriate. Remember that
>> once we graduate, we'll be moving repositories anyways, so it would
>> seem like a good opportunity to make structural changes.
>>
>> -Patrick
>>
>> On 5/7/07, Michael Dick <michael.d.dick@gmail.com> wrote:
>>> +1
>>>
>>> What would the impact be if we renamed openjpa-all to openjpa?
>>>
>>> We could change our checkout instructions to read
>>> svn co http://svn.apache.org/repos/asf/incubator/openjpa/ 
>>> trunkopenjpa-parent
>>> and then the directories match the artifactId's in pom.xml.
>>>
>>> The only reason I think this is worth doing is to avoid confusion  
>>> for new
>>> developers down the road. It's just one more thing that we have  
>>> to remember
>>> and explain. Maybe there's an impact to changing the directory  
>>> name that I
>>> missed though.
>>>
>>> -Mike
>>>
>>> On 5/6/07, Marc Prud'hommeaux <mprudhom@apache.org > wrote:
>>> >
>>> >
>>> > Poking around the ActiveMQ pom.xml files, I notice that you can  
>>> have
>>> > a different artifactId than the module name (i.e., directory)  
>>> you are
>>> > in. I hadn't known you could do this.
>>> >
>>> > Currently, our artifacts name are:
>>> >
>>> >    trunk/pom.xml: openjpa
>>> >    trunk/openjpa-all/pom.xml: openjpa-all
>>> >    trunk/openjpa-project/pom.xml: openjpa-project
>>> >
>>> > We could change these to:
>>> >
>>> >    trunk/pom.xml: openjpa-parent
>>> >    trunk/openjpa-all/pom.xml: openjpa
>>> >    trunk/openjpa-project/pom.xml: apache-openjpa
>>> >
>>> > I've tested this out, and it results in the openjpa aggregate jar
>>> > being named "openjpa-VERSION.jar", the dependency being simply  
>>> named
>>> > "openjpa", and the assembly is named "apache-openjpa- 
>>> VERSION.zip ".
>>> > None of the directories needed to be renamed. I've attached the  
>>> patch
>>> > that does this to https://issues.apache.org/jira/browse/ 
>>> OPENJPA-194
>>> >
>>> > Since this will mess up people who currently have maven  
>>> dependencies
>>> > on OpenJPA (i.e., people who depend on "openjpa-all" will now  
>>> need to
>>> > depend on "openjpa"), we should probably get this hammered out  
>>> before
>>> > leaving incubation. So I've gone ahead and turned the [DISCUSS]  
>>> into
>>> > a [VOTE] to see if we should go ahead and do this.
>>> >
>>> > A vote of +1 means we should do the renaming, -1 means we  
>>> should not,
>>> > and 0 means "don't care". The vote will remain open until  
>>> Wednesday
>>> > May 9th at 23:59 GMT.
>>> >
>>> >
>>> >
>>> >
>>> > On May 4, 2007, at 6:55 AM, Michael Dick wrote:
>>> >
>>> > > Some comments below
>>> > >
>>> > > On 5/4/07, Craig L Russell <Craig.Russell@sun.com > wrote:
>>> > >>
>>> > >> I'd like reopen the discussion on how to package and name our
>>> > >> artifacts. I think the current setup could be improved, to  
>>> give a
>>> > >> better experience for users who might not be using maven for
>>> > >> dependency management. It's easy for us to change now before
>>> > >> graduation because once we graduate, people will need to  
>>> update their
>>> > >> dependencies anyway so there are no backward compatibility  
>>> issues.
>>> > >>
>>> > >> The name of the single jar that has all of the openjpa stuff  
>>> in it
>>> > >> except for the documentation and examples is currently called
>>> > >> openjpa-
>>> > >> all. This name is confusing because unless they RTFM, people  
>>> don't
>>> > >> really know that it's not all the code you need, just all  
>>> the jpa
>>> > >> code. So I'd like to call this artifact openjpa.
>>> > >
>>> > >
>>> > > +1
>>> > >
>>> > > But we already have a project with that name, and that  
>>> project builds
>>> > >> the distributions. So I'd rename the current openjpa to  
>>> openjpa-dist.
>>> > >> Its ultimate destination in the Apache mirror structure is  
>>> under
>>> > >> www.apache.org/dist/openjpa once we graduate, so having dist  
>>> in the
>>> > >> project name helps understanding that this project builds the
>>> > >> artifacts that go into dist. Separate from the artifacts  
>>> that are
>>> > >> published via maven.
>>> > >
>>> > >
>>> > > +1
>>> > >
>>> > > Finally, the openjpa-all jar includes its subcomponents as
>>> > >> dependencies. I think this is wrong, since you end up with a  
>>> class
>>> > >> path with openjpa-all.jar as well as openjpa-kernel.jar and  
>>> all the
>>> > >> others.
>>> > >
>>> > >
>>> > > I would like to change this too. I did a little experimenting  
>>> and
>>> > > it looks
>>> > > like the dependencies aren't needed in openjpa-all, but they are
>>> > > needed for
>>> > > openjpa-project (to populate the lib directory). Moving the
>>> > > dependencies
>>> > > into openjpa-project should be safe.
>>> > >
>>> > > We're also going to need to change the deploy logic to strip  
>>> out the
>>> > > -project suffix from the zip files. We've talked about it before
>>> > > when I was
>>> > > releasing 0.9.7 (and before that when Marc was working on  
>>> 0.9.6),
>>> > > but I
>>> > > haven't had time to look into it. It should be fairly easy to  
>>> make the
>>> > > change.
>>> > >
>>> > >
>>> > > Thoughts?
>>> > >>
>>> > >> Craig
>>> > >>
>>> > >> Craig Russell
>>> > >> Architect, Sun Java Enterprise System http://java.sun.com/ 
>>> products/
>>> > >> jdo
>>> > >> 408 276-5638 mailto:Craig.Russell@sun.com
>>> > >> P.S. A good JDO? O, Gasp!
>>> > >>
>>> > >>
>>> > >>
>>> > > -Michael Dick
>>> >
>>> >
>>>
>>
>>
>> -- 
>> Patrick Linskey
>> 202 669 5907
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


--Apple-Mail-199-533162792
Content-Transfer-Encoding: base64
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Disposition: attachment;
	filename=smime.p7s

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw
ggJyoAMCAQICECpJVMO68ii+Xfsc1O1YYFIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx
JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA2MTIwOTE5NTEwNVoXDTA3MTIwOTE5NTEw
NVowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny
YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC
ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMNAB4Ih+ShsCt89HzqIdwEx8L4o1UHiY6V7
16mrCedfd4Y0/uI7z9Zam8ysgEh+F7aDnQEKmEsVFN35G4nPMfLU6dZYkvADwUjbq82t/dJ3FDDg
Q945nHHpqECZff/S/UMho9AFfj6PZvZBAlDCJAayb4RdKIlfuvPW9YcQStQ1IfVJcVuKnC0Q+tdc
a4A7zn7IzLOQohO1lTc3hXSBigEIGiGYn6Ny0wmexfA3X1WsXekFx5czd+M4GjDjswn8CNoBmnBr
jOTGK1mOsXR6GSRHnly2s9xTdE4qv9qimM+7C2yzMHbKcszV7OQoLsRsZKDh+6u9wYU+TrjcY4ym
bA8CAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC
MAAwDQYJKoZIhvcNAQEFBQADgYEAU/EpPDztnb55Fz7iGSVm1mYEVj5m2OQKTYG26POUAomCBRrt
/CdBBvqYmcHUTpra0qLELHAQadYFl2v11iQkqwF5PPJs19oU/zA0m5qFnOMTAiCvel7IprIwA2r6
eJR9siaPwDRgVJ/Sj71dD+utwf+nRrNy0/7PMNK5y+ocsYQwggM/MIICqKADAgECAgENMA0GCSqG
SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH
EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp
Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h
aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw
NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl
IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls
IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE
cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef
kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB
AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js
LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD
VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB
AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+
hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC
3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0ECECpJVMO68ii+Xfsc1O1YYFIwCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN
AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDcwNTA3MTY0NTQyWjAjBgkqhkiG9w0B
CQQxFgQUDrwYaJjD8qQhNJWOOQz5lhbqslEwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC
WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0
ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAqSVTDuvIovl37HNTtWGBSMIGHBgsqhkiG
9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ
dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAq
SVTDuvIovl37HNTtWGBSMA0GCSqGSIb3DQEBAQUABIIBAJztq60MH6rq2zV3sc9GqIpRtm9Nm/9X
YVsx40dWs/WaoWI0I/F37jc/iQhIkRdUVMKNyYslH6Px2Q/sL0gHvh4ZHnciCsf1XvKaAFVRCV4K
o6sUytly1dAcJqxchkH9i9Lqg+ldu3IHBL97mnFBXvKKRfH4pSzeIFQjHuFd0ymV4sS6bOcrgJ4j
BEdJBKHExBsJi4756rxtHNMDJjiavscPojZa6p4U9sRMFRULc7dW+2L/xZq6DuH11jcrQZR3Fdti
P5noGYo2u07X7q5p1EpdvRu9ngGie27rJJhbuZpu8811MNW4xr14qi2hFu41fKvDP2BfQbjJG9Ri
IyLsxfkAAAAAAAA=

--Apple-Mail-199-533162792--