Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 56538 invoked from network); 6 Apr 2007 21:17:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Apr 2007 21:17:26 -0000 Received: (qmail 45073 invoked by uid 500); 6 Apr 2007 21:17:33 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 45035 invoked by uid 500); 6 Apr 2007 21:17:33 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 45026 invoked by uid 99); 6 Apr 2007 21:17:33 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2007 14:17:33 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of awhite@bea.com designates 66.248.192.39 as permitted sender) Received: from [66.248.192.39] (HELO repmmg02.bea.com) (66.248.192.39) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2007 14:17:25 -0700 Received: from repmmr02.bea.com (repmmr02.bea.com [10.160.30.72]) by repmmg02.bea.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id l36LH3iL031259 for ; Fri, 6 Apr 2007 14:17:03 -0700 Received: from [10.0.1.9] ([10.43.242.47]) by repmmr02.bea.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id l36LH1AB012725 for ; Fri, 6 Apr 2007 14:17:02 -0700 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <7D856CDFE035FF45A0420ACBD71BDD6303D1F4EA@repbex02.amer.bea.com> References: <7D856CDFE035FF45A0420ACBD71BDD6303D1F4EA@repbex02.amer.bea.com> Content-Type: text/plain; charset=US-ASCII Message-Id: Content-Transfer-Encoding: 7bit From: Abe White Subject: Re: OPENJPA-182: reuse Connection constants or create our own? Date: Fri, 6 Apr 2007 16:16:48 -0500 To: open-jpa-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.3) x-BEA-PMX-Instructions: AV x-BEA-MM: Internal-To-External X-Virus-Checked: Checked by ClamAV on apache.org > I think that JDBCFetchPlan should take a Java 5 enum, and > JDBCFetchConfiguration should use the Connection values. Certainly JDBCFetchConfiguration should use the Connection values. I personally have never had a problem with symbolic constants for settings, but enums for the FetchPlan are cool too. So long as the JPA QueryImpl parses the enum value and its string form correctly when using it as a hint. Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.