Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: open-jpa-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of ritikamster@gmail.com
 designates 66.249.90.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=ehPw02oK2aRczhCKquSOVtuY6MUL+mRJK0Cj6tiQFjhAJ0Szz2AAtePFsSzmVbHZnR1mtYB9hUWThQoJSwu0JfylGLzKh72nunVBmXgTmQquJ3MDr5hDx+ADic1S94ZD9XZgTqIcCdV2ZlKrIgMQ4anOGWS8GBIlerLVcE0H5xM=
Message-ID: <7a5e6f6a0704061014x12621517j7738403280e4647d@mail.gmail.com>
Date: Fri, 6 Apr 2007 10:14:22 -0700
From: "Ritika Maheshwari" <ritikamster@gmail.com>
To: open-jpa-dev@incubator.apache.org
Subject: Re: svn commit: r526212 - in
 /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc:
 kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
In-Reply-To: <20070406160828.3A3791A9838@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_9043_23564454.1175879662331"
References: <20070406160828.3A3791A9838@eris.apache.org>

------=_Part_9043_23564454.1175879662331
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Patrick,
             With your recent changes regarding the OPENJPA-182 The logic
has changed a little.What was intended was that if the forUpdate flag = true
we append the FOR UPDATE CLAUSE.But in case of DB2 if the forUpdate flag =
false then we append FOR READ ONLY clause.Now the FOR READ ONLY Clause is
not getting generated.This is because you moved toOperation back to
DBDictionary and there you check if (forUpdate && !simulateLocking) then
append forUpdateClause.Well in this case forUpdate is false and we still
want the forUpdateClause.That was the reason I had overridden the
toOperation in DB2Dictionary and was just checking (!simulateLocking) before
appending the forUpdate Clause.


On 4/6/07, pcl@apache.org <pcl@apache.org> wrote:
>
> Author: pcl
> Date: Fri Apr  6 09:08:27 2007
> New Revision: 526212
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> Log:
> OPENJPA-182
>
> Modified:
>
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
>
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
>
> Modified:
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> URL:
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java?view=diff&rev=526212&r1=526211&r2=526212
>
> ==============================================================================
> ---
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> (original)
> +++
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> Fri Apr  6 09:08:27 2007
> @@ -327,7 +327,7 @@
>     }
>
>     public JDBCFetchConfiguration setIsolationLevel(int level) {
> -        if (level != -1
> +        if (level != -1 && level != DEFAULT
>             && level != Connection.TRANSACTION_NONE
>             && level != Connection.TRANSACTION_READ_UNCOMMITTED
>             && level != Connection.TRANSACTION_READ_COMMITTED
> @@ -335,8 +335,11 @@
>             && level != Connection.TRANSACTION_SERIALIZABLE)
>             throw new IllegalArgumentException(
>                 _loc.get("bad-level", Integer.valueOf
> (level)).getMessage());
> -
> -        _state.isolationLevel = level;
> +
> +        if (level == DEFAULT)
> +            _state.isolationLevel = -1;
> +        else
> +            _state.isolationLevel = level;
>         return this;
>     }
> }
>
> Modified:
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
> URL:
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java?view=diff&rev=526212&r1=526211&r2=526212
>
> ==============================================================================
> ---
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
> (original)
> +++
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
> Fri Apr  6 09:08:27 2007
> @@ -2205,8 +2205,8 @@
>
>         if (forUpdate && !simulateLocking) {
>             assertSupport(supportsSelectForUpdate,
> "SupportsSelectForUpdate");
> -            if (this.forUpdateClause != null)
> -                buf.append(" ").append(this.forUpdateClause);
> +            if (forUpdateClause != null)
> +                buf.append(" ").append(forUpdateClause);
>         }
>         if (range && rangePosition == RANGE_POST_LOCK)
>             appendSelectRange(buf, start, end);
>
>
>

------=_Part_9043_23564454.1175879662331--