Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: open-jpa-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of mprudhomapache@gmail.com
 designates 66.249.82.236 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer:sender;
        b=LOkelUcyG6IFFsIp2k7SjeML8wB+9NwdNaRz2rpjQzkYPGge3bVdhcfXOZYtKvAs5ZpVtacrKZnUNxwarjzLww+m4VSfbT5F90e8vsDSlwXt3aa6zHSLzATPBRW18wdED3KCm//QKJkW/TQ8hvkIyyKxwmfkoIzg+lckyQWw/yQ=
Mime-Version: 1.0 (Apple Message framework v752.3)
In-Reply-To: <111912D0-8DC3-4FE6-8D27-2BF1E476C02A@iq80.com>
References: <C468E26B-71CF-4CCB-8348-3DC3B4EBC159@iq80.com>
 <111912D0-8DC3-4FE6-8D27-2BF1E476C02A@iq80.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <0DA24A0A-19D3-48EF-AFB2-363430178745@apache.org>
Content-Transfer-Encoding: 7bit
From: Marc Prud'hommeaux <mprudhom@apache.org>
Subject: Re: [VOTE] ArgumentException : More parameters were passed to
 execute() than were declared
Date: Sun, 1 Apr 2007 12:30:15 -0400
To: open-jpa-dev@incubator.apache.org
Sender: Marc Prud'hommeaux <mprudhomapache@gmail.com>


Seem fair enough to get rid of the description. I've opened https:// 
issues.apache.org/jira/browse/OPENJPA-196 describing the issue.

+1 from me to remove the restriction that there be exactly as many  
positional parameters declared as were assigned.


On Mar 31, 2007, at 7:32 PM, Dain Sundstrom wrote:

> Actually, I think there is a bigger problem...  Say I have a query  
> like this:
>
>     SELECT x FROM foo AS x WHERE foo.name = ?2
>
> The org.apache.openjpa.kernel.QueryImpl.assertParameters(...) code  
> assumes that if I have 1 parameter it is numbered ?1, but in EJB  
> 2.1 this was not a requirement and there are certification tests  
> that verify you are allowed to have "unused" parameters (e.g, in my  
> example about ?1 and ?N where N>2 are all not used).  I couldn't  
> find any text in the specification that says that all all  
> positional parameters must be used in the query, but I did find  
> text that say the EJB-QL 3.0 language is an extension of the EJB-QL  
> 2.1 language:
>
> "The Java Persistence query language is an extension of the  
> Enterprise Java Beans query language, EJB QL, definedin[5]."
>
> So I think we must remove the "extra-params" check, but I would be  
> happy with a "don't check for extra-params flag".
>
> -dain
>
> On Mar 31, 2007, at 8:56 AM, Dain Sundstrom wrote:
>
>> I'm working on a CMP 2 implementation that delegates to OpenJPA  
>> for persistence.  I'm running into a problem where I get the  
>> following exception:
>>
>> org.apache.openjpa.persistence.ArgumentException : More parameters  
>> were passed to execute() than were declared: 4 parameters were  
>> specified for query execution, but only 2 parameters were declared  
>> in the query.
>>
>>
>> In CMP you declare finder and select methods that have parameters  
>> which are passed into the query engine.  You can have as many  
>> parameters as you like but are not required to use them all, but  
>> it appears that OpenJPA is enforcing a restriction where if the  
>> EJB-QL text only lists say 2 parameters and I set 4 I get the  
>> above exception.  In order of perference:
>>
>> Is this spec required? If not, can we remove the check?
>>
>> Is there a way to disable the check?  If so, how?
>>
>> Is there a way to determine the number of paramters a query  
>> takes?  If so, I can change my code.
>>
>> Is there a way to get the ejbql text from a Query object? If so,  
>> I'll write a quick parser to determine number of queries myself.
>>
>> BTW, I'm currently using 0.9.6.
>>
>> Thanks,
>>
>> -dain
>