From open-jpa-dev-return-3416-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org Wed Apr 11 23:06:42 2007 Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 58260 invoked from network); 11 Apr 2007 23:06:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Apr 2007 23:06:42 -0000 Received: (qmail 25652 invoked by uid 500); 11 Apr 2007 23:06:48 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 25528 invoked by uid 500); 11 Apr 2007 23:06:48 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 25515 invoked by uid 99); 11 Apr 2007 23:06:48 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2007 16:06:48 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of plinskey@bea.com designates 66.248.192.39 as permitted sender) Received: from [66.248.192.39] (HELO repmmg02.bea.com) (66.248.192.39) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2007 16:06:41 -0700 Received: from repmmr01.bea.com (repmmr01.bea.com [10.160.29.71]) by repmmg02.bea.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id l3BN6J1A005115; Wed, 11 Apr 2007 16:06:19 -0700 Received: from repbex02.amer.bea.com (repbex02.bea.com [10.160.26.99]) by repmmr01.bea.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id l3BN6EuH004655; Wed, 11 Apr 2007 16:06:18 -0700 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: RE: Testing an OpenJPA module Date: Wed, 11 Apr 2007 16:05:23 -0700 Message-ID: <7D856CDFE035FF45A0420ACBD71BDD6303E4060B@repbex02.amer.bea.com> In-Reply-To: <5C219175D559A64D8C2CC65E41D36856FC4E23@repbex01.amer.bea.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Testing an OpenJPA module Thread-Index: Acd8hlJLNE5bV+RbQim7iLIZYDqN8wABgbyAAABS9dA= References: <592F1AD0-F492-49F1-9CC4-54F254413851@apache.org> <359919ED-60B0-43FF-A8F5-6A0C22D015D9@apache.org> <0A84E9AA-5A99-4876-B63C-E6DC7DE4A9C0@apache.org> <1b5bfeb50704101252q11f38194v8a3919de6a07391@mail.gmail.com> <5C219175D559A64D8C2CC65E41D36856FC4852@repbex01.amer.bea.com> <5C219175D559A64D8C2CC65E41D36856FC4A33@repbex01.amer.bea.com> <5C219175D559A64D8C2CC65E41D36856FC4E23@repbex01.amer.bea.com> From: "Patrick Linskey" To: Cc: "cmp-dev" x-BEA-PMX-Instructions: AV x-BEA-MM: Internal-To-External X-Virus-Checked: Checked by ClamAV on apache.org Hi, Pinaki's change is a big improvement. I think that we can even go a bit further by returning a List from findAllProviders(), and then if the EMF lookup fails, we can include those exceptions in the PersistenceException that is returned. -Patrick -- Patrick Linskey BEA Systems, Inc. _______________________________________________________________________ Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it. > -----Original Message----- > From: Pinaki Poddar > Sent: Wednesday, April 11, 2007 3:55 PM > To: open-jpa-dev@incubator.apache.org > Cc: cmp-dev > Subject: RE: Testing an OpenJPA module > > Hello Craig, > Done. > Thanks for your advice. > > Please review: > https://glassfish.dev.java.net/issues/show_bug.cgi?id=2814 > > Pinaki Poddar > BEA Systems > 415.402.7317 > > > -----Original Message----- > From: Craig.Russell@Sun.COM [mailto:Craig.Russell@Sun.COM] > Sent: Wednesday, April 11, 2007 5:11 PM > To: open-jpa-dev@incubator.apache.org > Cc: cmp-dev > Subject: Re: Testing an OpenJPA module > > Hi Pinaki, > > On Apr 10, 2007, at 6:44 PM, Pinaki Poddar wrote: > > >> provide a patch. > > Will such a patch be given to Glassfish project? > > But some kind of committer-level privilege will be required, i > > suppose. > > > > have added few more informative messages to distinguish between > > different ways persistence unit creation/ lookup can fail. > > please advise on how to proceed on contributing a patch. > > This is great. Can you please file a Glassfish/persistence issue in > their issue tracker and attach your patch? If you have trouble doing > this, I'll be glad to help some more... > > Thanks! > > Craig > > > > > > Pinaki Poddar > > BEA Systems > > 415.402.7317 > > > > > > -----Original Message----- > > From: Craig.Russell@Sun.COM [mailto:Craig.Russell@Sun.COM] > > Sent: Tuesday, April 10, 2007 4:14 PM > > To: open-jpa-dev@incubator.apache.org > > Subject: Re: Testing an OpenJPA module > > > > FYI, Persistence is an open source project at Glassfish. > > > > Anyone, even an OpenJPA contributor, who wants to contribute to the > > project for example to improve the error messages, is > welcome to look > > at the sources and provide a patch. I know people who will > be happy to > > > commit usability patches. ;-) > > > > Craig > > > > On Apr 10, 2007, at 1:54 PM, Pinaki Poddar wrote: > > > >> The error message could have been more specific in the > following way: > >> a) no META-INF/persistence.xml has not been found in classpath > >> b) META-INF/persistence.xml has been found but there is no 'ode- > >> store' > >> unit defined in it. > >> c) META-INF/persistence.xml has been found but provider > can not be > >> loaded/invoked > >> > >> When I first encountered this error, my interpreation was (b) from > >> the way the message was worded. > >> > >> > >> Pinaki Poddar > >> BEA Systems > >> 415.402.7317 > >> > >> > >> -----Original Message----- > >> From: eljotpl@gmail.com [mailto:eljotpl@gmail.com] On > Behalf Of Jacek > > >> Laskowski > >> Sent: Tuesday, April 10, 2007 2:52 PM > >> To: open-jpa-dev@incubator.apache.org > >> Subject: Re: Testing an OpenJPA module > >> > >> On 4/10/07, Marc Prud'hommeaux wrote: > >>> > >>> Glad you got it fixed. It's annoying that > >>> javax.persistence.Persistence doesn't provide more of a > clue as to > >>> why > >> > >>> it failed. > >> > >> I wonder what else you'd like to see other than what's already > >> printed out? It tells exactly why it's failed - "No Persistence > >> provider for EntityManager named ode-store" is just a JPA > version of > >> "NoClassDefFoundError" in "pure" Java. > >> > >> Jacek > >> > >> -- > >> Jacek Laskowski > >> http://www.JacekLaskowski.pl > >> > >> Notice: This email message, together with any attachments, may > >> contain information of BEA Systems, Inc., its > subsidiaries and > >> affiliated entities, that may be confidential, proprietary, > >> copyrighted and/or legally privileged, and is intended solely for > >> the use of the individual or entity named in this message. > If you are > > >> not the intended recipient, and have received this message > in error, > >> please immediately return this by email and then delete it. > > > > Craig Russell > > Architect, Sun Java Enterprise System > http://java.sun.com/products/jdo > > 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! > > > > > > Notice: This email message, together with any attachments, may > > contain information of BEA Systems, Inc., its subsidiaries > > and affiliated entities, that may be confidential, > proprietary, > > copyrighted and/or legally privileged, and is intended solely for > > the use of the individual or entity named in this message. If you > > are not the intended recipient, and have received this message in > > error, please immediately return this by email and then delete it. > > Craig Russell > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo > 408 276-5638 mailto:Craig.Russell@sun.com > P.S. A good JDO? O, Gasp! > > > Notice: This email message, together with any attachments, > may contain information of BEA Systems, Inc., its > subsidiaries and affiliated entities, that may be > confidential, proprietary, copyrighted and/or legally > privileged, and is intended solely for the use of the > individual or entity named in this message. If you are not > the intended recipient, and have received this message in > error, please immediately return this by email and then delete it. > Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.