Return-Path: 
 <open-jpa-dev-return-2456-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org
Received: (qmail 12561 invoked from network); 27 Feb 2007 20:05:26 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 27 Feb 2007 20:05:26 -0000
Received: (qmail 12506 invoked by uid 500); 27 Feb 2007 20:05:35 -0000
Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org
Received: (qmail 12485 invoked by uid 500); 27 Feb 2007 20:05:35 -0000
Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:open-jpa-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:open-jpa-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:open-jpa-dev@incubator.apache.org>
List-Id: <open-jpa-dev.incubator.apache.org>
Reply-To: open-jpa-dev@incubator.apache.org
Delivered-To: mailing list open-jpa-dev@incubator.apache.org
Received: (qmail 12476 invoked by uid 99); 27 Feb 2007 20:05:34 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2007 12:05:34 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2007 12:05:25 -0800
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 98EC771403E
	for <open-jpa-dev@incubator.apache.org>;
 Tue, 27 Feb 2007 12:05:05 -0800 (PST)
Message-ID: <12807628.1172606705614.JavaMail.jira@brutus>
Date: Tue, 27 Feb 2007 12:05:05 -0800 (PST)
From: "Craig Russell (JIRA)" <jira@apache.org>
To: open-jpa-dev@incubator.apache.org
Subject: [jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects
In-Reply-To: <20132722.1172166545512.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476353 ] 

Craig Russell commented on OPENJPA-160:
---------------------------------------

The real cost according to the trace is in the dynamically created class, not in BrokerImpl<init>.

I don't get it either, except to think that the implementation of the dynamically created class uses reflection itself, which is slow.

To see if this is the case, we'll need to create a real compiler-generated factory, like this:

openjpa-kernel/src/main/java/org/apache/openjpa/conf/OpenJPAConfigurationImpl.java
...
        brokerPlugin.registerInstanceFactory(BrokerImpl.class.getName(), 
            new BrokerInstanceFactory();
...
       public class BrokerInstanceFactory implements ObjectValue.InstanceFactory {
                public Object newInstance() {
                    return new BrokerImpl();
                } 
...


> Reuse BrokerImpl objects
> ------------------------
>
>                 Key: OPENJPA-160
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-160
>             Project: OpenJPA
>          Issue Type: Sub-task
>            Reporter: Michael Dick
>         Assigned To: Patrick Linskey
>         Attachments: newprofile.jpg, openjpa-160-patch.txt, openjpa-160-patch.txt, perf2.jpg, perf3.jpg
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.