From open-jpa-dev-return-2406-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org Mon Feb 26 23:24:27 2007 Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 77867 invoked from network); 26 Feb 2007 23:24:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Feb 2007 23:24:26 -0000 Received: (qmail 75720 invoked by uid 500); 26 Feb 2007 23:24:35 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 75602 invoked by uid 500); 26 Feb 2007 23:24:34 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 75593 invoked by uid 99); 26 Feb 2007 23:24:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2007 15:24:34 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2007 15:24:25 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 7E6CD71403D for ; Mon, 26 Feb 2007 15:24:05 -0800 (PST) Message-ID: <2888546.1172532245500.JavaMail.jira@brutus> Date: Mon, 26 Feb 2007 15:24:05 -0800 (PST) From: "Patrick Linskey (JIRA)" To: open-jpa-dev@incubator.apache.org Subject: [jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects In-Reply-To: <20132722.1172166545512.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476039 ] Patrick Linskey commented on OPENJPA-160: ----------------------------------------- The profiling data seems to point to reflection as the culprit; the init() call is very very fast. Could someone with access to the benchmark try out just calling 'new BrokerImpl() from JDBCConfigurationImpl or something? That should tell us a lot about where the cost is coming from. WRT per-thread pooling -- it sounds like you're proposing that we would actually share brokers between multiple EMs in the same thread. I think that that would have a lot of undesired consequences, would certainly violate a bunch of the intent of the JPA spec, and would probably fail in the CTS. In OpenJPA, each logical EM definitely needs to have access to a unique Broker. Pooling could help us reduce the cost of obtaining such a Broker, but sharing would be a pretty significant semantic change. > Reuse BrokerImpl objects > ------------------------ > > Key: OPENJPA-160 > URL: https://issues.apache.org/jira/browse/OPENJPA-160 > Project: OpenJPA > Issue Type: Sub-task > Reporter: Michael Dick > Attachments: perf2.jpg, perf3.jpg > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.