openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sutter" <kwsut...@gmail.com>
Subject Re: svn commit: r502392 - /incubator/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/AbstractBrokerFactory.java
Date Fri, 02 Feb 2007 03:00:59 GMT
Good point.  I'll clean that up on my next commit.

Kevin

On 2/1/07, Craig L Russell <Craig.Russell@sun.com> wrote:
>
> Hi Kevin,
>
> Good changes.
>
> Here's where I would have put a comment:
>
> On Feb 1, 2007, at 2:53 PM, kwsutter@apache.org wrote:
>
> >              Broker broker;
> >              for (Iterator itr = _brokers.iterator(); itr.hasNext
> > ();) {
> >                  broker = (Broker) itr.next();
> > -                if (!broker.isClosed())
> /* Check for null here because _brokers is a weak reference
> collection */
> > +                if ((broker != null) && (!broker.isClosed()))
> >                      broker.close();
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message