openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abe White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-161) Overuse of synchronization in AbstractBrokerFactory
Date Fri, 23 Feb 2007 16:05:05 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475374
] 

Abe White commented on OPENJPA-161:
-----------------------------------

The code in question (just after the FIXME) is still guarding against the same transaction
in concurrent threads.  See the "someone beat us to it" putIfAbsent call.  If we agree that
transactions are thread bound -- as must be the case for the rest of the patch to be correct
-- no one can "beat us to it", because we're the only thread with access to that transaction.
 

> Overuse of synchronization in AbstractBrokerFactory
> ---------------------------------------------------
>
>                 Key: OPENJPA-161
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-161
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: kernel
>            Reporter: Patrick Linskey
>         Attachments: openjpa-161-patch.txt
>
>
> AbstractBrokerFactory maintains a Map<Transaction,List<Broker>> that is guarded
by synchronized blocks. These synchronized blocks should be removed if possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message