Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 11093 invoked from network); 15 Nov 2006 00:04:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Nov 2006 00:04:48 -0000 Received: (qmail 3999 invoked by uid 500); 15 Nov 2006 00:04:58 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 3981 invoked by uid 500); 15 Nov 2006 00:04:58 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 3972 invoked by uid 99); 15 Nov 2006 00:04:58 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2006 16:04:58 -0800 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: 63.246.7.35 is neither permitted nor denied by domain of bwnoll@gmail.com) Received: from [63.246.7.35] (HELO mail.virtuas.com) (63.246.7.35) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2006 16:04:44 -0800 Received: (qmail 27960 invoked by uid 89); 15 Nov 2006 00:04:23 -0000 Received: by simscan 1.1.0 ppid: 27911, pid: 27915, t: 8.4938s scanners: clamav: m: spam: 3.0.2 Received: from unknown (HELO ?127.0.0.1?) (bnoll@virtuas.com@71.216.65.30) by smtp.virtuas.com with SMTP; 15 Nov 2006 00:04:14 -0000 Message-ID: <455A597D.30906@gmail.com> Date: Tue, 14 Nov 2006 17:04:13 -0700 From: Bryan Noll User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) MIME-Version: 1.0 To: open-jpa-dev@incubator.apache.org Subject: Re: openjpa.Id property References: <7D856CDFE035FF45A0420ACBD71BDD630271BE6D@repbex02.amer.bea.com> In-Reply-To: <7D856CDFE035FF45A0420ACBD71BDD630271BE6D@repbex02.amer.bea.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 0648-2, 11/14/2006), Outbound message X-Antivirus-Status: Clean X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on virtuas01.managed.contegix.com X-Spam-Level: X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.2 I don't feel super strongly... but I tend to lean towards less is more. If all you need for the time being is the Id concept, do that. Throw in a quick documentation note about what exactly that property is... and then if people need to use just the p-name part of it, they can run with handy ole java.lang.String. If there's demand for it (via the mailing list or whatever)... then it can be added.... Nice work on breaking out the word 'somesuch'... I'm gonna have to steal that... --Bryan Patrick Linskey wrote: > So I'm having a bit of a hard time with this property setting. > > In many environments, it makes a lot of sense to line up the > openjpa.PersistenceUnitName property with the setting in the persistence.xml > file. However, in an appserver, that name might not be unique. We (BEA) > sometimes need to be able to get the "fully-qualified" persistence unit > name, which is probably most closely defined in a Java EE environment as > application-name.module-name.persistence-unit-name or somesuch. > > But obviously, if I create a property called openjpa.PersistenceUnitName, > people would (understandably) assume that the property should contain just > persistence-unit-name, and not the fully-qualified beast. That's why I was > thinking along the terms of 'Id' instead of 'PersistenceUnitName'. > > Do others agree that these concepts are not quite the same? If so, should I > create a property for each (since PersistenceUnitName might be useful), or > should I just create the ID-related one, since that's all I really need > right now? > > -Patrick > >