From open-jpa-dev-return-1112-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org Thu Nov 09 00:01:15 2006 Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 17802 invoked from network); 9 Nov 2006 00:01:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Nov 2006 00:01:13 -0000 Received: (qmail 64197 invoked by uid 500); 9 Nov 2006 00:01:24 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 64103 invoked by uid 500); 9 Nov 2006 00:01:24 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 64094 invoked by uid 99); 9 Nov 2006 00:01:24 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2006 16:01:24 -0800 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of michael.d.dick@gmail.com designates 64.233.184.235 as permitted sender) Received: from [64.233.184.235] (HELO wr-out-0506.google.com) (64.233.184.235) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2006 16:01:10 -0800 Received: by wr-out-0506.google.com with SMTP id i28so10950wra for ; Wed, 08 Nov 2006 16:00:49 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=mmuswGCKx4OewHy1n7X24fSUoWW63L0j6xILNQtxGhlpsJp95UWN0HUJgS3Qhk6BLM5aK7FnPOhUr6eQmc0LX79EQ4MGAYpRJkO69l3K1DBn8eVdKm+uDDi2zjml7H9rfrIf4uCecYm2aSNeL1W6z/5X9i7TqFWM/OyZTSVC/gY= Received: by 10.65.23.7 with SMTP id a7mr268969qbj.1163030448776; Wed, 08 Nov 2006 16:00:48 -0800 (PST) Received: by 10.65.241.10 with HTTP; Wed, 8 Nov 2006 16:00:48 -0800 (PST) Message-ID: <72c1350f0611081600s53df10cah64ad236606833d7a@mail.gmail.com> Date: Wed, 8 Nov 2006 18:00:48 -0600 From: "Michael Dick" To: open-jpa-dev@incubator.apache.org Subject: Re: svn commit: r472680 - /incubator/openjpa/trunk/openjpa-project/assembly.xml In-Reply-To: <051B10EA-9319-463D-A878-45104FFF8CC3@apache.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_21880_494186.1163030448739" References: <20061108225942.6BF841A9846@eris.apache.org> <72c1350f0611081533i783a027fn2665f00888d64fbb@mail.gmail.com> <72c1350f0611081550i36458669nfa13a1b2125fdda0@mail.gmail.com> <051B10EA-9319-463D-A878-45104FFF8CC3@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_21880_494186.1163030448739 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline I'm fine with leaving it in - it shouldn't hold up the release, I just wanted it noted. I should have mentioned that in the first post. Better to take the time and get it fixed right rather than hack something in anyway :-) On 11/8/06, Marc Prud'hommeaux wrote: > > > Can we live with the "-all-" name for right now? I'm trying to get > ready to vote on a release, and I've found that playing with that > stuff can wind up being a lot more time consuming than I always > expect it to be. > > > > On Nov 8, 2006, at 3:50 PM, Michael Dick wrote: > > > No, I was seeing the same thing. I ended up creating a jar- > > assembly.xml file > > which unpacked openjpa-all-${version}.jar to a temp directory then > > re-jarred > > it as /target/aggregate/openjpa-${version}.jar. Then I noticed you > > already > > fixed the problem. > > > > I don't particularly like recreating the jar, but if it'll help I > > can send a > > patch of what I had. > > > > On 11/8/06, Marc Prud'hommeaux wrote: > >> > >> > >> I'd be happy to have a non "-all" suffixed jar, but without my last > >> change, I wasn't seeing *any* openjpaXXX.jar file being put into > >> the .zip package. > >> > >> Are you seeing something different? > >> > >> > >> On Nov 8, 2006, at 3:33 PM, Michael Dick wrote: > >> > >> > This puts the -all suffix back into the jar name. We took it out in > >> > OPENJPA-65. It's just a name, might not be a big deal. > >> > > >> > I'm not sure if there's a good way to remove the -all suffix. I > >> > suppose one > >> > could unpack openjpa-all-${version} and repackage it (I think > >> > that's what we > >> > were doing before). It's probably possible to have a script rename > >> > the jar > >> > before the zip gets created too, but the timing might get tricky. > >> > > >> > Or maybe I'm missing something I've tried it with clean build and > >> > without > >> > this time though :-) > >> > -Mike > >> > > >> > On 11/8/06, mprudhom@apache.org wrote: > >> >> > >> >> Author: mprudhom > >> >> Date: Wed Nov 8 14:59:41 2006 > >> >> New Revision: 472680 > >> >> > >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=472680 > >> >> Log: > >> >> Manually include the openjpa-all module in the zip file. For some > >> >> reason, > >> >> it wasn't being included in the package. > >> >> > >> >> Modified: > >> >> incubator/openjpa/trunk/openjpa-project/assembly.xml > >> >> > >> >> Modified: incubator/openjpa/trunk/openjpa-project/assembly.xml > >> >> URL: > >> >> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa- > >> >> project/assembly.xml?view=diff&rev=472680&r1=472679&r2=472680 > >> >> > >> >> > >> ===================================================================== > >> >> ========= > >> >> --- incubator/openjpa/trunk/openjpa-project/assembly.xml > >> (original) > >> >> +++ incubator/openjpa/trunk/openjpa-project/assembly.xml Wed > >> Nov 8 > >> >> 14:59:41 2006 > >> >> @@ -59,6 +59,14 @@ > >> >> > >> >> > >> >> > >> >> + / > >> >> + false > >> >> + runtime > >> >> + > >> >> + org.apache.openjpa:openjpa-all > >> >> + > >> >> + > >> >> + > >> >> /lib > >> >> false > >> >> runtime > >> >> > >> >> > >> > >> > > > > > > -- > > -Michael Dick > > -- -Michael Dick ------=_Part_21880_494186.1163030448739--