openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eddie O'Neil" <>
Subject Re: [VOTE] publish openjpa 0.9.5-incubating podling release
Date Sun, 12 Nov 2006 05:11:32 GMT
  Great job on this release -- we're really down to nitty-little
detail issues with the distribution.  More detailed comments are below
-- the highlights fall into two major buckets:

#1: information needed in NOTICE.txt.  This refers to the ActiveMQ
project; it also needs to refer to the source files for the binary
persistence-api JAR file as per the CDDL 1.0 license.  More
information on ASF policy relative to this license is here:

Additionally, NOTICE.txt should contain the copyrights for 3rd party
Serp / persistence-api JARs.  For example:

#2: ASF source headers.  There are a bunch of files in the source
distribution that don't have source headers.  There's a great tool
that one of the Incubator PMC members wrote that checks for these
headers.  It's super easy to checkout, build, and run and can be found

These are listed below.

  -1 until #1 is fixed because we need to be compliant with licenses
of bundled 3rd party JARs.  I'd suggest fixing #2 as well but leave
that to the community to decide -- though the Incubator PMC is looking
more closely at license headers these days.  :)


Items checked:
  - md5 signatures
  - sha1 signatures
  - license headers on archived files
  - example builds and runs
  - documentation looks good
  - license compatibility of JAR files

Issues that should be addressed before release:
- NOTICE.txt references the "ActiveMQ" distribution
- as per CDDL 1.0, NOTICE.txt must refer to the source for the
persistence-api sources.  For more information about including CDDL
1.0 licensed binaries, see:
- source archive includes sun/misc/
- files missing license files:
    - **/*.properties
    - **/pom.xml
    - **/*.xml
    - **/*.rsrc
    - **/JPQL.jjt
    - **/*.ProductDerivation
    - **/*.ExpressionParser
    - **/*.PersistenceProvider
- Java files without LICENSE headers -- there were 17 of these.  Found using:
    find . -name "*.java" -exec grep --files-without-match "LICENSE" {} ;
- openjpa-project-0.9.6-incubating.pom missing license header

Minor issues:
- Javadoc includes a couple of extraneous classes
- JARs are named "openjpa-project-0.9.6-incubating" but unzip into
- distribution files that can be removed
- no .tar.gz archives

On 11/9/06, Kevin Sutter <> wrote:
> +1
> On 11/9/06, Abe White <> wrote:
> >
> > +1
> > _______________________________________________________________________
> > Notice:  This email message, together with any attachments, may contain
> > information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
> > entities,  that may be confidential,  proprietary,  copyrighted  and/or
> > legally privileged, and is intended solely for the use of the individual
> > or entity named in this message. If you are not the intended recipient,
> > and have received this message in error, please immediately return this
> > by email and then delete it.
> >

View raw message